You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2020/11/09 08:50:37 UTC

[Impala-ASF-CR] IMPALA-10145,IMPALA-10299: Bump impala-shell thrift version to 0.11.0-p4 

Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16700


Change subject: IMPALA-10145,IMPALA-10299: Bump impala-shell thrift version to 0.11.0-p4
......................................................................

IMPALA-10145,IMPALA-10299: Bump impala-shell thrift version to 0.11.0-p4

Currently, impala-shell depends on thrift-0.11.0-p2, while impala
servers depend on thrift-0.9.3-p8. After 0.10.0, thrift changes its
internal strings representation from bytes to unicode (THRIFT-3503) to
support Python3. THRIFT-2087 and THRIFT-5303 are two patches for
specifying an error handling method in decoding utf-8 strings in thrift.
Without them, impala-shell may get an unexpected UnicodeDecodeError when
decoding thrift objects from impala servers. This patch bumps
impala-shell's thrift version to 0.11.0-p4 to include these two patches.

Tests:
 - This is a regression after we bump impala-shell's thrift version to
   0.11. Added a test to avoid the regression in the future.

Change-Id: I0f9898639b5648658efc2d3c5c0ee4721fb85776
---
M bin/impala-config.sh
M tests/shell/test_shell_commandline.py
2 files changed, 12 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/16700/1
-- 
To view, visit http://gerrit.cloudera.org:8080/16700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0f9898639b5648658efc2d3c5c0ee4721fb85776
Gerrit-Change-Number: 16700
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-10145,IMPALA-10299: Bump impala-shell thrift version to 0.11.0-p4

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16700 )

Change subject: IMPALA-10145,IMPALA-10299: Bump impala-shell thrift version to 0.11.0-p4
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/16700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f9898639b5648658efc2d3c5c0ee4721fb85776
Gerrit-Change-Number: 16700
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Nov 2020 04:25:49 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10145,IMPALA-10299: Bump impala-shell thrift version to 0.11.0-p4

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16700 )

Change subject: IMPALA-10145,IMPALA-10299: Bump impala-shell thrift version to 0.11.0-p4
......................................................................


Patch Set 1:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/7620/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/16700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f9898639b5648658efc2d3c5c0ee4721fb85776
Gerrit-Change-Number: 16700
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Nov 2020 08:55:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10145,IMPALA-10299: Bump impala-shell thrift version to 0.11.0-p4

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16700 )

Change subject: IMPALA-10145,IMPALA-10299: Bump impala-shell thrift version to 0.11.0-p4
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6636/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/16700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f9898639b5648658efc2d3c5c0ee4721fb85776
Gerrit-Change-Number: 16700
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Nov 2020 23:02:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10145,IMPALA-10299: Bump impala-shell thrift version to 0.11.0-p4

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16700 )

Change subject: IMPALA-10145,IMPALA-10299: Bump impala-shell thrift version to 0.11.0-p4
......................................................................

IMPALA-10145,IMPALA-10299: Bump impala-shell thrift version to 0.11.0-p4

Currently, impala-shell depends on thrift-0.11.0-p2, while impala
servers depend on thrift-0.9.3-p8. After 0.10.0, thrift changes its
internal strings representation from bytes to unicode (THRIFT-3503) to
support Python3. THRIFT-2087 and THRIFT-5303 are two patches for
specifying an error handling method in decoding utf-8 strings in thrift.
Without them, impala-shell may get an unexpected UnicodeDecodeError when
decoding thrift objects from impala servers. This patch bumps
impala-shell's thrift version to 0.11.0-p4 to include these two patches.

Tests:
 - This is a regression after we bump impala-shell's thrift version to
   0.11. Added a test to avoid the regression in the future.

Change-Id: I0f9898639b5648658efc2d3c5c0ee4721fb85776
Reviewed-on: http://gerrit.cloudera.org:8080/16700
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/impala-config.sh
M tests/shell/test_shell_commandline.py
2 files changed, 12 insertions(+), 2 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/16700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0f9898639b5648658efc2d3c5c0ee4721fb85776
Gerrit-Change-Number: 16700
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-10145,IMPALA-10299: Bump impala-shell thrift version to 0.11.0-p4

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16700

to look at the new patch set (#2).

Change subject: IMPALA-10145,IMPALA-10299: Bump impala-shell thrift version to 0.11.0-p4
......................................................................

IMPALA-10145,IMPALA-10299: Bump impala-shell thrift version to 0.11.0-p4

Currently, impala-shell depends on thrift-0.11.0-p2, while impala
servers depend on thrift-0.9.3-p8. After 0.10.0, thrift changes its
internal strings representation from bytes to unicode (THRIFT-3503) to
support Python3. THRIFT-2087 and THRIFT-5303 are two patches for
specifying an error handling method in decoding utf-8 strings in thrift.
Without them, impala-shell may get an unexpected UnicodeDecodeError when
decoding thrift objects from impala servers. This patch bumps
impala-shell's thrift version to 0.11.0-p4 to include these two patches.

Tests:
 - This is a regression after we bump impala-shell's thrift version to
   0.11. Added a test to avoid the regression in the future.

Change-Id: I0f9898639b5648658efc2d3c5c0ee4721fb85776
---
M bin/impala-config.sh
M tests/shell/test_shell_commandline.py
2 files changed, 12 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/16700/2
-- 
To view, visit http://gerrit.cloudera.org:8080/16700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0f9898639b5648658efc2d3c5c0ee4721fb85776
Gerrit-Change-Number: 16700
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-10145,IMPALA-10299: Bump impala-shell thrift version to 0.11.0-p4

Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16700 )

Change subject: IMPALA-10145,IMPALA-10299: Bump impala-shell thrift version to 0.11.0-p4
......................................................................


Patch Set 2: Code-Review+2

LGTM


-- 
To view, visit http://gerrit.cloudera.org:8080/16700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f9898639b5648658efc2d3c5c0ee4721fb85776
Gerrit-Change-Number: 16700
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Nov 2020 17:56:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10145,IMPALA-10299: Bump impala-shell thrift version to 0.11.0-p4

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16700 )

Change subject: IMPALA-10145,IMPALA-10299: Bump impala-shell thrift version to 0.11.0-p4
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/7621/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/16700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f9898639b5648658efc2d3c5c0ee4721fb85776
Gerrit-Change-Number: 16700
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Nov 2020 09:15:26 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10145,IMPALA-10299: Bump impala-shell thrift version to 0.11.0-p4

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16700 )

Change subject: IMPALA-10145,IMPALA-10299: Bump impala-shell thrift version to 0.11.0-p4
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f9898639b5648658efc2d3c5c0ee4721fb85776
Gerrit-Change-Number: 16700
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Nov 2020 23:02:32 +0000
Gerrit-HasComments: No