You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "张铎(Duo Zhang)" <pa...@gmail.com> on 2024/05/25 13:39:41 UTC

[DISCUSS] About setting regionserver implementation in TableOutputFormat

Now we have these codes in TableOutputFormat

https://github.com/apache/hbase/blob/2130e5410f63fead548d14c11d3b439e0d98f603/hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/TableOutputFormat.java#L217

      if (serverClass != null) {
        this.conf.set(HConstants.REGION_SERVER_IMPL, serverImpl);
      }

It was added in HBASE-2221, when we wanted to implement MR based table
copy. Does anyone still remember the reason why we wanted to specify
region server class and implementation when copying a table? It does
not make sense to me...

Thanks.

Re: [DISCUSS] About setting regionserver implementation in TableOutputFormat

Posted by "张铎(Duo Zhang)" <pa...@gmail.com>.
Filed HBASE-28616 for removing/deprecating these useless fields and methods.

The PR is ready

https://github.com/apache/hbase/pull/5946

Thanks.

张铎(Duo Zhang) <pa...@gmail.com> 于2024年5月25日周六 21:45写道：
>
> OK, after blaming, I think we do not need to support these things any more...
>
> The related code in CopyTable had already been removed in HBASE-6044...
>
> Let me file an issue to remove these in the TableOutputFormat class too.
>
> 张铎(Duo Zhang) <pa...@gmail.com> 于2024年5月25日周六 21:39写道：
> >
> > Now we have these codes in TableOutputFormat
> >
> > https://github.com/apache/hbase/blob/2130e5410f63fead548d14c11d3b439e0d98f603/hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/TableOutputFormat.java#L217
> >
> >       if (serverClass != null) {
> >         this.conf.set(HConstants.REGION_SERVER_IMPL, serverImpl);
> >       }
> >
> > It was added in HBASE-2221, when we wanted to implement MR based table
> > copy. Does anyone still remember the reason why we wanted to specify
> > region server class and implementation when copying a table? It does
> > not make sense to me...
> >
> > Thanks.

Re: [DISCUSS] About setting regionserver implementation in TableOutputFormat

Posted by "张铎(Duo Zhang)" <pa...@gmail.com>.
OK, after blaming, I think we do not need to support these things any more...

The related code in CopyTable had already been removed in HBASE-6044...

Let me file an issue to remove these in the TableOutputFormat class too.

张铎(Duo Zhang) <pa...@gmail.com> 于2024年5月25日周六 21:39写道：
>
> Now we have these codes in TableOutputFormat
>
> https://github.com/apache/hbase/blob/2130e5410f63fead548d14c11d3b439e0d98f603/hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/TableOutputFormat.java#L217
>
>       if (serverClass != null) {
>         this.conf.set(HConstants.REGION_SERVER_IMPL, serverImpl);
>       }
>
> It was added in HBASE-2221, when we wanted to implement MR based table
> copy. Does anyone still remember the reason why we wanted to specify
> region server class and implementation when copying a table? It does
> not make sense to me...
>
> Thanks.