You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "wesleydeng (Code Review)" <ge...@cloudera.org> on 2020/11/24 11:45:17 UTC

[Impala-ASF-CR] IMPALA-10323: use gutil to cast int to string

wesleydeng has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/16719 )

Change subject: IMPALA-10323: use gutil to cast int to string
......................................................................

IMPALA-10323: use gutil to cast int to string

Using gutil instead of lexical_cast when casting int type
value to string, performance can be improved significantly
in multi-thread mode. In contrast, performance using
lexical_cast decreased seriously in multi-thread mode.
For example:
when mt_dop=8, this change can get 20x performance
improvement;
when mt_dop=0, this change can get 2x performance
improvement;

Change-Id: Ief1d6b2c2cb5961c1d6cee1b0eac86ab61509768
---
M be/src/exprs/cast-functions-ir.cc
1 file changed, 34 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/16719/7
-- 
To view, visit http://gerrit.cloudera.org:8080/16719
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ief1d6b2c2cb5961c1d6cee1b0eac86ab61509768
Gerrit-Change-Number: 16719
Gerrit-PatchSet: 7
Gerrit-Owner: wesleydeng <we...@tencent.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: abeltian <ab...@tencent.com>
Gerrit-Reviewer: wesleydeng <we...@tencent.com>