[jira] [Created] (MESOS-5191) Broken credentials file accepted without error

["Benjamin Bannier (JIRA)" <ji...@apache.org>]

Benjamin Bannier created MESOS-5191:
---------------------------------------

             Summary: Broken credentials file accepted without error
                 Key: MESOS-5191
                 URL: https://issues.apache.org/jira/browse/MESOS-5191
             Project: Mesos
          Issue Type: Bug
            Reporter: Benjamin Bannier


Starting a mesos agent with the following broken JSON credentials currently emits no error
{code}
{
  "principal": "username",
  "secret": "secret"
}
{code}

A correct JSON format would have been
{code}
{
  "credentials": [
    {
      "principal": "username",
      "secret": "secret"
    }
  ]
}
{code}

No diagnostic is emitted in the agent log and (as expected) {{username:secret}}
cannot be used to authenticate.

>From adding some logging to {{mesos::internal::credentials::read}} it seems while above broken format is successfully rejected by the JSON parser, the current fall-though logic next tries the parser for the legacy credentials format which finds no credentials at all. This seems confusing as we have specified some (albeit broken) information.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)