You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org> on 2012/04/26 08:13:21 UTC

[jira] [Created] (HBASE-5882) Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor

ramkrishna.s.vasudevan created HBASE-5882:
---------------------------------------------

             Summary: Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor
                 Key: HBASE-5882
                 URL: https://issues.apache.org/jira/browse/HBASE-5882
             Project: HBase
          Issue Type: Improvement
    Affects Versions: 0.92.1, 0.90.6
            Reporter: ramkrishna.s.vasudevan
            Assignee: ramkrishna.s.vasudevan
             Fix For: 0.90.7, 0.96.0, 0.94.1


Currently on  master restart if it tries to do processRIT, any region if found on dead server tries to avoid the nwe assignment so that timeout monitor can take care.
This case is more prominent if the node is found in RS_ZK_REGION_OPENING state. I think we can handle this by triggering a new assignment with a new plan.



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5882) Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278630#comment-13278630 ] 

Hadoop QA commented on HBASE-5882:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12528004/hbase_5882_V2.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 hadoop23.  The patch compiles against the hadoop 0.23.x profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 32 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.TestRegionRebalancing
                  org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks
                  org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster
                  org.apache.hadoop.hbase.master.TestAssignmentManager

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1925//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1925//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1925//console

This message is automatically generated.
                
> Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5882
>                 URL: https://issues.apache.org/jira/browse/HBASE-5882
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.6, 0.92.1
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: hbase_5882.patch, hbase_5882_V2.patch
>
>
> Currently on  master restart if it tries to do processRIT, any region if found on dead server tries to avoid the nwe assignment so that timeout monitor can take care.
> This case is more prominent if the node is found in RS_ZK_REGION_OPENING state. I think we can handle this by triggering a new assignment with a new plan.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5882) Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279513#comment-13279513 ] 

Hudson commented on HBASE-5882:
-------------------------------

Integrated in HBase-TRUNK #2908 (See [https://builds.apache.org/job/HBase-TRUNK/2908/])
    HBASE-5882 Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor (Ashutosh) (Revision 1340392)

     Result = FAILURE
ramkrishna : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java

                
> Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5882
>                 URL: https://issues.apache.org/jira/browse/HBASE-5882
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.6, 0.92.1, 0.94.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Ashutosh Jindal
>             Fix For: 0.96.0, 0.94.1
>
>         Attachments: HBASE-5882_v5.patch, hbase_5882.patch, hbase_5882_V2.patch, hbase_5882_V3.patch, hbase_5882_V4.patch
>
>
> Currently on  master restart if it tries to do processRIT, any region if found on dead server tries to avoid the nwe assignment so that timeout monitor can take care.
> This case is more prominent if the node is found in RS_ZK_REGION_OPENING state. I think we can handle this by triggering a new assignment with a new plan.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5882) Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279537#comment-13279537 ] 

Hudson commented on HBASE-5882:
-------------------------------

Integrated in HBase-TRUNK #2909 (See [https://builds.apache.org/job/HBase-TRUNK/2909/])
    HBASE-5882 (Revert) TestAssginmentManager needs some cleanup (Revision 1340422)

     Result = FAILURE
ramkrishna : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java

                
> Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5882
>                 URL: https://issues.apache.org/jira/browse/HBASE-5882
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.6, 0.92.1, 0.94.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Ashutosh Jindal
>             Fix For: 0.96.0, 0.94.1
>
>         Attachments: HBASE-5882_v5.patch, hbase_5882.patch, hbase_5882_V2.patch, hbase_5882_V3.patch, hbase_5882_V4.patch
>
>
> Currently on  master restart if it tries to do processRIT, any region if found on dead server tries to avoid the nwe assignment so that timeout monitor can take care.
> This case is more prominent if the node is found in RS_ZK_REGION_OPENING state. I think we can handle this by triggering a new assignment with a new plan.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5882) Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280316#comment-13280316 ] 

Hudson commented on HBASE-5882:
-------------------------------

Integrated in HBase-TRUNK #2910 (See [https://builds.apache.org/job/HBase-TRUNK/2910/])
    HBASE-5882 Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor (Ashutosh) (Revision 1341110)

     Result = FAILURE
ramkrishna : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java

                
> Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5882
>                 URL: https://issues.apache.org/jira/browse/HBASE-5882
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.6, 0.92.1, 0.94.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Ashutosh Jindal
>             Fix For: 0.96.0, 0.94.1
>
>         Attachments: HBASE-5882_v5.patch, HBASE-5882_v6.patch, hbase_5882.patch, hbase_5882_V2.patch, hbase_5882_V3.patch, hbase_5882_V4.patch
>
>
> Currently on  master restart if it tries to do processRIT, any region if found on dead server tries to avoid the nwe assignment so that timeout monitor can take care.
> This case is more prominent if the node is found in RS_ZK_REGION_OPENING state. I think we can handle this by triggering a new assignment with a new plan.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5882) Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor

Posted by "Ashutosh Jindal (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashutosh Jindal updated HBASE-5882:
-----------------------------------

    Status: Open  (was: Patch Available)
    
> Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5882
>                 URL: https://issues.apache.org/jira/browse/HBASE-5882
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.92.1, 0.90.6
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: hbase_5882.patch, hbase_5882_V2.patch
>
>
> Currently on  master restart if it tries to do processRIT, any region if found on dead server tries to avoid the nwe assignment so that timeout monitor can take care.
> This case is more prominent if the node is found in RS_ZK_REGION_OPENING state. I think we can handle this by triggering a new assignment with a new plan.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5882) Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276975#comment-13276975 ] 

Hadoop QA commented on HBASE-5882:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12527664/hbase_5882.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 hadoop23.  The patch compiles against the hadoop 0.23.x profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 31 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.master.TestSplitLogManager

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1891//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1891//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1891//console

This message is automatically generated.
                
> Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5882
>                 URL: https://issues.apache.org/jira/browse/HBASE-5882
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.6, 0.92.1
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: hbase_5882.patch
>
>
> Currently on  master restart if it tries to do processRIT, any region if found on dead server tries to avoid the nwe assignment so that timeout monitor can take care.
> This case is more prominent if the node is found in RS_ZK_REGION_OPENING state. I think we can handle this by triggering a new assignment with a new plan.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5882) Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor

Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276981#comment-13276981 ] 

ramkrishna.s.vasudevan commented on HBASE-5882:
-----------------------------------------------

@Ted
Is the name 'wasOnDeadServer' ok?
But the name was given lik that because this change is done for RS_ZK_OPENING state. Based on your suggestion i can change it and commit it.
                
> Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5882
>                 URL: https://issues.apache.org/jira/browse/HBASE-5882
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.6, 0.92.1
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: hbase_5882.patch
>
>
> Currently on  master restart if it tries to do processRIT, any region if found on dead server tries to avoid the nwe assignment so that timeout monitor can take care.
> This case is more prominent if the node is found in RS_ZK_REGION_OPENING state. I think we can handle this by triggering a new assignment with a new plan.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5882) Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor

Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277550#comment-13277550 ] 

ramkrishna.s.vasudevan commented on HBASE-5882:
-----------------------------------------------

Will commit today unless objections.  Will make the method name as 'wasOnDeadServer'. Any comments pls share.
                
> Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5882
>                 URL: https://issues.apache.org/jira/browse/HBASE-5882
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.6, 0.92.1
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: hbase_5882.patch
>
>
> Currently on  master restart if it tries to do processRIT, any region if found on dead server tries to avoid the nwe assignment so that timeout monitor can take care.
> This case is more prominent if the node is found in RS_ZK_REGION_OPENING state. I think we can handle this by triggering a new assignment with a new plan.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5882) Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor

Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ramkrishna.s.vasudevan updated HBASE-5882:
------------------------------------------

    Attachment: HBASE-5882_v6.patch

Just a clean up in TestAssignmentManager.java.
Restored the default class of LoadBalancer.
                
> Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5882
>                 URL: https://issues.apache.org/jira/browse/HBASE-5882
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.6, 0.92.1, 0.94.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Ashutosh Jindal
>             Fix For: 0.96.0, 0.94.1
>
>         Attachments: HBASE-5882_v5.patch, HBASE-5882_v6.patch, hbase_5882.patch, hbase_5882_V2.patch, hbase_5882_V3.patch, hbase_5882_V4.patch
>
>
> Currently on  master restart if it tries to do processRIT, any region if found on dead server tries to avoid the nwe assignment so that timeout monitor can take care.
> This case is more prominent if the node is found in RS_ZK_REGION_OPENING state. I think we can handle this by triggering a new assignment with a new plan.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5882) Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor

Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279060#comment-13279060 ] 

Zhihong Yu commented on HBASE-5882:
-----------------------------------

I don't see what is different in patch v4 compared to patch v3.
                
> Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5882
>                 URL: https://issues.apache.org/jira/browse/HBASE-5882
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.6, 0.92.1
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Ashutosh Jindal
>         Attachments: hbase_5882.patch, hbase_5882_V2.patch, hbase_5882_V3.patch, hbase_5882_V4.patch
>
>
> Currently on  master restart if it tries to do processRIT, any region if found on dead server tries to avoid the nwe assignment so that timeout monitor can take care.
> This case is more prominent if the node is found in RS_ZK_REGION_OPENING state. I think we can handle this by triggering a new assignment with a new plan.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (HBASE-5882) Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor

Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ramkrishna.s.vasudevan reassigned HBASE-5882:
---------------------------------------------

    Assignee: Ashutosh Jindal  (was: ramkrishna.s.vasudevan)
    
> Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5882
>                 URL: https://issues.apache.org/jira/browse/HBASE-5882
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.6, 0.92.1
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Ashutosh Jindal
>         Attachments: hbase_5882.patch, hbase_5882_V2.patch, hbase_5882_V3.patch
>
>
> Currently on  master restart if it tries to do processRIT, any region if found on dead server tries to avoid the nwe assignment so that timeout monitor can take care.
> This case is more prominent if the node is found in RS_ZK_REGION_OPENING state. I think we can handle this by triggering a new assignment with a new plan.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5882) Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor

Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ramkrishna.s.vasudevan updated HBASE-5882:
------------------------------------------

    Attachment: hbase_5882_V4.patch

Updated patch addressing Ted's comments.
I can commit this if the patch is ok.
                
> Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5882
>                 URL: https://issues.apache.org/jira/browse/HBASE-5882
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.6, 0.92.1
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Ashutosh Jindal
>         Attachments: hbase_5882.patch, hbase_5882_V2.patch, hbase_5882_V3.patch, hbase_5882_V4.patch
>
>
> Currently on  master restart if it tries to do processRIT, any region if found on dead server tries to avoid the nwe assignment so that timeout monitor can take care.
> This case is more prominent if the node is found in RS_ZK_REGION_OPENING state. I think we can handle this by triggering a new assignment with a new plan.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5882) Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280653#comment-13280653 ] 

Hudson commented on HBASE-5882:
-------------------------------

Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #13 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/13/])
    HBASE-5882 Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor (Ashutosh) (Revision 1341110)

     Result = FAILURE
ramkrishna : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java

                
> Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5882
>                 URL: https://issues.apache.org/jira/browse/HBASE-5882
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.6, 0.92.1, 0.94.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Ashutosh Jindal
>             Fix For: 0.96.0, 0.94.1
>
>         Attachments: HBASE-5882_v5.patch, HBASE-5882_v6.patch, hbase_5882.patch, hbase_5882_V2.patch, hbase_5882_V3.patch, hbase_5882_V4.patch
>
>
> Currently on  master restart if it tries to do processRIT, any region if found on dead server tries to avoid the nwe assignment so that timeout monitor can take care.
> This case is more prominent if the node is found in RS_ZK_REGION_OPENING state. I think we can handle this by triggering a new assignment with a new plan.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5882) Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor

Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ramkrishna.s.vasudevan updated HBASE-5882:
------------------------------------------

    Affects Version/s: 0.94.0
        Fix Version/s: 0.94.1
                       0.96.0
    
> Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5882
>                 URL: https://issues.apache.org/jira/browse/HBASE-5882
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.6, 0.92.1, 0.94.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Ashutosh Jindal
>             Fix For: 0.96.0, 0.94.1
>
>         Attachments: HBASE-5882_v5.patch, hbase_5882.patch, hbase_5882_V2.patch, hbase_5882_V3.patch, hbase_5882_V4.patch
>
>
> Currently on  master restart if it tries to do processRIT, any region if found on dead server tries to avoid the nwe assignment so that timeout monitor can take care.
> This case is more prominent if the node is found in RS_ZK_REGION_OPENING state. I think we can handle this by triggering a new assignment with a new plan.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5882) Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor

Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278569#comment-13278569 ] 

Zhihong Yu commented on HBASE-5882:
-----------------------------------

wasOnDeadServer is Okay.
                
> Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5882
>                 URL: https://issues.apache.org/jira/browse/HBASE-5882
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.6, 0.92.1
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: hbase_5882.patch
>
>
> Currently on  master restart if it tries to do processRIT, any region if found on dead server tries to avoid the nwe assignment so that timeout monitor can take care.
> This case is more prominent if the node is found in RS_ZK_REGION_OPENING state. I think we can handle this by triggering a new assignment with a new plan.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5882) Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279636#comment-13279636 ] 

Hudson commented on HBASE-5882:
-------------------------------

Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #12 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/12/])
    HBASE-5882 (Revert) TestAssginmentManager needs some cleanup (Revision 1340422)

     Result = FAILURE
ramkrishna : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java

                
> Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5882
>                 URL: https://issues.apache.org/jira/browse/HBASE-5882
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.6, 0.92.1, 0.94.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Ashutosh Jindal
>             Fix For: 0.96.0, 0.94.1
>
>         Attachments: HBASE-5882_v5.patch, hbase_5882.patch, hbase_5882_V2.patch, hbase_5882_V3.patch, hbase_5882_V4.patch
>
>
> Currently on  master restart if it tries to do processRIT, any region if found on dead server tries to avoid the nwe assignment so that timeout monitor can take care.
> This case is more prominent if the node is found in RS_ZK_REGION_OPENING state. I think we can handle this by triggering a new assignment with a new plan.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5882) Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor

Posted by "Ashutosh Jindal (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashutosh Jindal updated HBASE-5882:
-----------------------------------

    Fix Version/s:     (was: 0.94.1)
                       (was: 0.96.0)
                       (was: 0.90.7)
     Hadoop Flags: Reviewed
           Status: Patch Available  (was: Open)
    
> Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5882
>                 URL: https://issues.apache.org/jira/browse/HBASE-5882
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.92.1, 0.90.6
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: hbase_5882.patch
>
>
> Currently on  master restart if it tries to do processRIT, any region if found on dead server tries to avoid the nwe assignment so that timeout monitor can take care.
> This case is more prominent if the node is found in RS_ZK_REGION_OPENING state. I think we can handle this by triggering a new assignment with a new plan.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5882) Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor

Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279023#comment-13279023 ] 

Zhihong Yu commented on HBASE-5882:
-----------------------------------

{code}
+        } else if (wasOnDeadServer(sn, deadServers)){
{code}
since regionInfo was not one of the parameters to wasOnDeadServer(), the method name still doesn't make sense.
I think we can directly place the check ( deadServers.keySet().contains(sn) ) above. This way there is no need to introduce a new method.
                
> Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5882
>                 URL: https://issues.apache.org/jira/browse/HBASE-5882
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.6, 0.92.1
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: hbase_5882.patch, hbase_5882_V2.patch, hbase_5882_V3.patch
>
>
> Currently on  master restart if it tries to do processRIT, any region if found on dead server tries to avoid the nwe assignment so that timeout monitor can take care.
> This case is more prominent if the node is found in RS_ZK_REGION_OPENING state. I think we can handle this by triggering a new assignment with a new plan.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (HBASE-5882) Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor

Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ramkrishna.s.vasudevan resolved HBASE-5882.
-------------------------------------------

    Resolution: Fixed

Committed the patch. Hence resolving this.
                
> Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5882
>                 URL: https://issues.apache.org/jira/browse/HBASE-5882
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.6, 0.92.1, 0.94.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Ashutosh Jindal
>             Fix For: 0.96.0, 0.94.1
>
>         Attachments: HBASE-5882_v5.patch, HBASE-5882_v6.patch, hbase_5882.patch, hbase_5882_V2.patch, hbase_5882_V3.patch, hbase_5882_V4.patch
>
>
> Currently on  master restart if it tries to do processRIT, any region if found on dead server tries to avoid the nwe assignment so that timeout monitor can take care.
> This case is more prominent if the node is found in RS_ZK_REGION_OPENING state. I think we can handle this by triggering a new assignment with a new plan.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5882) Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278716#comment-13278716 ] 

Hadoop QA commented on HBASE-5882:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12528025/hbase_5882_V3.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 hadoop23.  The patch compiles against the hadoop 0.23.x profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 32 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.master.TestSplitLogManager
                  org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1928//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1928//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1928//console

This message is automatically generated.
                
> Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5882
>                 URL: https://issues.apache.org/jira/browse/HBASE-5882
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.6, 0.92.1
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: hbase_5882.patch, hbase_5882_V2.patch, hbase_5882_V3.patch
>
>
> Currently on  master restart if it tries to do processRIT, any region if found on dead server tries to avoid the nwe assignment so that timeout monitor can take care.
> This case is more prominent if the node is found in RS_ZK_REGION_OPENING state. I think we can handle this by triggering a new assignment with a new plan.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5882) Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor

Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ramkrishna.s.vasudevan updated HBASE-5882:
------------------------------------------

    Fix Version/s:     (was: 0.94.1)

Committed to trunk only.
                
> Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5882
>                 URL: https://issues.apache.org/jira/browse/HBASE-5882
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.6, 0.92.1, 0.94.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Ashutosh Jindal
>             Fix For: 0.96.0
>
>         Attachments: HBASE-5882_v5.patch, HBASE-5882_v6.patch, hbase_5882.patch, hbase_5882_V2.patch, hbase_5882_V3.patch, hbase_5882_V4.patch
>
>
> Currently on  master restart if it tries to do processRIT, any region if found on dead server tries to avoid the nwe assignment so that timeout monitor can take care.
> This case is more prominent if the node is found in RS_ZK_REGION_OPENING state. I think we can handle this by triggering a new assignment with a new plan.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5882) Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor

Posted by "Ashutosh Jindal (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashutosh Jindal updated HBASE-5882:
-----------------------------------

    Attachment: hbase_5882_V3.patch

Updated patch for 0.96. 
                
> Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5882
>                 URL: https://issues.apache.org/jira/browse/HBASE-5882
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.6, 0.92.1
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: hbase_5882.patch, hbase_5882_V2.patch, hbase_5882_V3.patch
>
>
> Currently on  master restart if it tries to do processRIT, any region if found on dead server tries to avoid the nwe assignment so that timeout monitor can take care.
> This case is more prominent if the node is found in RS_ZK_REGION_OPENING state. I think we can handle this by triggering a new assignment with a new plan.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5882) Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor

Posted by "Ashutosh Jindal (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashutosh Jindal updated HBASE-5882:
-----------------------------------

    Attachment: hbase_5882_V2.patch

Submitted updated patch. Please review and provide suggestions/comments.
                
> Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5882
>                 URL: https://issues.apache.org/jira/browse/HBASE-5882
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.6, 0.92.1
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: hbase_5882.patch, hbase_5882_V2.patch
>
>
> Currently on  master restart if it tries to do processRIT, any region if found on dead server tries to avoid the nwe assignment so that timeout monitor can take care.
> This case is more prominent if the node is found in RS_ZK_REGION_OPENING state. I think we can handle this by triggering a new assignment with a new plan.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5882) Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor

Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278670#comment-13278670 ] 

ramkrishna.s.vasudevan commented on HBASE-5882:
-----------------------------------------------

The latest test case failure in TestAssignmentManager is due to the impact of the testcase that went in HBASE-5927.  A small tweak will make it work.  

                
> Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5882
>                 URL: https://issues.apache.org/jira/browse/HBASE-5882
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.6, 0.92.1
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: hbase_5882.patch, hbase_5882_V2.patch
>
>
> Currently on  master restart if it tries to do processRIT, any region if found on dead server tries to avoid the nwe assignment so that timeout monitor can take care.
> This case is more prominent if the node is found in RS_ZK_REGION_OPENING state. I think we can handle this by triggering a new assignment with a new plan.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5882) Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279064#comment-13279064 ] 

stack commented on HBASE-5882:
------------------------------

Patch looks good to me.

For the next time, instead of

{code}
+    if (deadServers.keySet().contains(sn)) {
+      return true;
+    }
+    return false;
{code}

Why not just

{code}
return deadServers.keySet().contains(sn)
{code}
                
> Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5882
>                 URL: https://issues.apache.org/jira/browse/HBASE-5882
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.6, 0.92.1
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Ashutosh Jindal
>         Attachments: hbase_5882.patch, hbase_5882_V2.patch, hbase_5882_V3.patch, hbase_5882_V4.patch
>
>
> Currently on  master restart if it tries to do processRIT, any region if found on dead server tries to avoid the nwe assignment so that timeout monitor can take care.
> This case is more prominent if the node is found in RS_ZK_REGION_OPENING state. I think we can handle this by triggering a new assignment with a new plan.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5882) Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor

Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ramkrishna.s.vasudevan updated HBASE-5882:
------------------------------------------

    Status: Open  (was: Patch Available)
    
> Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5882
>                 URL: https://issues.apache.org/jira/browse/HBASE-5882
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.92.1, 0.90.6
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Ashutosh Jindal
>         Attachments: HBASE-5882_v5.patch, hbase_5882.patch, hbase_5882_V2.patch, hbase_5882_V3.patch, hbase_5882_V4.patch
>
>
> Currently on  master restart if it tries to do processRIT, any region if found on dead server tries to avoid the nwe assignment so that timeout monitor can take care.
> This case is more prominent if the node is found in RS_ZK_REGION_OPENING state. I think we can handle this by triggering a new assignment with a new plan.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5882) Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor

Posted by "Ashutosh Jindal (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashutosh Jindal updated HBASE-5882:
-----------------------------------

    Status: Open  (was: Patch Available)
    
> Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5882
>                 URL: https://issues.apache.org/jira/browse/HBASE-5882
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.92.1, 0.90.6
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: hbase_5882.patch, hbase_5882_V2.patch
>
>
> Currently on  master restart if it tries to do processRIT, any region if found on dead server tries to avoid the nwe assignment so that timeout monitor can take care.
> This case is more prominent if the node is found in RS_ZK_REGION_OPENING state. I think we can handle this by triggering a new assignment with a new plan.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5882) Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor

Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279535#comment-13279535 ] 

ramkrishna.s.vasudevan commented on HBASE-5882:
-----------------------------------------------

Currently reverted as TestAssignmentManager needs some clean up.
                
> Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5882
>                 URL: https://issues.apache.org/jira/browse/HBASE-5882
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.6, 0.92.1, 0.94.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Ashutosh Jindal
>             Fix For: 0.96.0, 0.94.1
>
>         Attachments: HBASE-5882_v5.patch, hbase_5882.patch, hbase_5882_V2.patch, hbase_5882_V3.patch, hbase_5882_V4.patch
>
>
> Currently on  master restart if it tries to do processRIT, any region if found on dead server tries to avoid the nwe assignment so that timeout monitor can take care.
> This case is more prominent if the node is found in RS_ZK_REGION_OPENING state. I think we can handle this by triggering a new assignment with a new plan.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5882) Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor

Posted by "Ashutosh Jindal (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashutosh Jindal updated HBASE-5882:
-----------------------------------

    Attachment: hbase_5882.patch

Submitted patch for 0.96. Please review and provide your suggestions/comments.
                
> Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5882
>                 URL: https://issues.apache.org/jira/browse/HBASE-5882
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.6, 0.92.1
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: hbase_5882.patch
>
>
> Currently on  master restart if it tries to do processRIT, any region if found on dead server tries to avoid the nwe assignment so that timeout monitor can take care.
> This case is more prominent if the node is found in RS_ZK_REGION_OPENING state. I think we can handle this by triggering a new assignment with a new plan.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5882) Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor

Posted by "Ashutosh Jindal (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashutosh Jindal updated HBASE-5882:
-----------------------------------

    Status: Patch Available  (was: Open)
    
> Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5882
>                 URL: https://issues.apache.org/jira/browse/HBASE-5882
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.92.1, 0.90.6
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: hbase_5882.patch, hbase_5882_V2.patch
>
>
> Currently on  master restart if it tries to do processRIT, any region if found on dead server tries to avoid the nwe assignment so that timeout monitor can take care.
> This case is more prominent if the node is found in RS_ZK_REGION_OPENING state. I think we can handle this by triggering a new assignment with a new plan.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5882) Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor

Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279505#comment-13279505 ] 

ramkrishna.s.vasudevan commented on HBASE-5882:
-----------------------------------------------

Committed to trunk. Thanks for the patch Ashutosh.
Thanks for the review Stack and Ted.
                
> Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5882
>                 URL: https://issues.apache.org/jira/browse/HBASE-5882
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.6, 0.92.1
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Ashutosh Jindal
>         Attachments: HBASE-5882_v5.patch, hbase_5882.patch, hbase_5882_V2.patch, hbase_5882_V3.patch, hbase_5882_V4.patch
>
>
> Currently on  master restart if it tries to do processRIT, any region if found on dead server tries to avoid the nwe assignment so that timeout monitor can take care.
> This case is more prominent if the node is found in RS_ZK_REGION_OPENING state. I think we can handle this by triggering a new assignment with a new plan.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5882) Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor

Posted by "Ashutosh Jindal (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashutosh Jindal updated HBASE-5882:
-----------------------------------

    Status: Patch Available  (was: Open)
    
> Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5882
>                 URL: https://issues.apache.org/jira/browse/HBASE-5882
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.92.1, 0.90.6
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: hbase_5882.patch, hbase_5882_V2.patch, hbase_5882_V3.patch
>
>
> Currently on  master restart if it tries to do processRIT, any region if found on dead server tries to avoid the nwe assignment so that timeout monitor can take care.
> This case is more prominent if the node is found in RS_ZK_REGION_OPENING state. I think we can handle this by triggering a new assignment with a new plan.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5882) Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor

Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276963#comment-13276963 ] 

Zhihong Yu commented on HBASE-5882:
-----------------------------------

Idea is good.
{code}
+  private boolean wasOpeningOnDeadServer(ServerName sn,
+      Map<ServerName, List<Pair<HRegionInfo, Result>>> deadServers) {
+    if (deadServers.keySet().contains(sn)) {
{code}
The above method doesn't check whether regionInfo is in opening state. So the name of method should be changed accordingly.
                
> Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5882
>                 URL: https://issues.apache.org/jira/browse/HBASE-5882
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.6, 0.92.1
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: hbase_5882.patch
>
>
> Currently on  master restart if it tries to do processRIT, any region if found on dead server tries to avoid the nwe assignment so that timeout monitor can take care.
> This case is more prominent if the node is found in RS_ZK_REGION_OPENING state. I think we can handle this by triggering a new assignment with a new plan.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5882) Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor

Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ramkrishna.s.vasudevan updated HBASE-5882:
------------------------------------------

    Attachment: HBASE-5882_v5.patch

Ah, sorry. I uploaded the wrong one from my machine.
                
> Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5882
>                 URL: https://issues.apache.org/jira/browse/HBASE-5882
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.6, 0.92.1
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Ashutosh Jindal
>         Attachments: HBASE-5882_v5.patch, hbase_5882.patch, hbase_5882_V2.patch, hbase_5882_V3.patch, hbase_5882_V4.patch
>
>
> Currently on  master restart if it tries to do processRIT, any region if found on dead server tries to avoid the nwe assignment so that timeout monitor can take care.
> This case is more prominent if the node is found in RS_ZK_REGION_OPENING state. I think we can handle this by triggering a new assignment with a new plan.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5882) Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279525#comment-13279525 ] 

Hudson commented on HBASE-5882:
-------------------------------

Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #11 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/11/])
    HBASE-5882 Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor (Ashutosh) (Revision 1340392)

     Result = FAILURE
ramkrishna : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java

                
> Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5882
>                 URL: https://issues.apache.org/jira/browse/HBASE-5882
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.6, 0.92.1, 0.94.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Ashutosh Jindal
>             Fix For: 0.96.0, 0.94.1
>
>         Attachments: HBASE-5882_v5.patch, hbase_5882.patch, hbase_5882_V2.patch, hbase_5882_V3.patch, hbase_5882_V4.patch
>
>
> Currently on  master restart if it tries to do processRIT, any region if found on dead server tries to avoid the nwe assignment so that timeout monitor can take care.
> This case is more prominent if the node is found in RS_ZK_REGION_OPENING state. I think we can handle this by triggering a new assignment with a new plan.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5882) Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor

Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279088#comment-13279088 ] 

ramkrishna.s.vasudevan commented on HBASE-5882:
-----------------------------------------------

@Ted
If you are ok with v5 i can commit it tomorrow. Thanks. Going to bed now :)
                
> Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5882
>                 URL: https://issues.apache.org/jira/browse/HBASE-5882
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.6, 0.92.1
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Ashutosh Jindal
>         Attachments: HBASE-5882_v5.patch, hbase_5882.patch, hbase_5882_V2.patch, hbase_5882_V3.patch, hbase_5882_V4.patch
>
>
> Currently on  master restart if it tries to do processRIT, any region if found on dead server tries to avoid the nwe assignment so that timeout monitor can take care.
> This case is more prominent if the node is found in RS_ZK_REGION_OPENING state. I think we can handle this by triggering a new assignment with a new plan.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5882) Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor

Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279091#comment-13279091 ] 

Zhihong Yu commented on HBASE-5882:
-----------------------------------

Patch v5 looks good.
                
> Prcoess RIT on master restart can try assigning the region if the region is found on a dead server instead of waiting for Timeout Monitor
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5882
>                 URL: https://issues.apache.org/jira/browse/HBASE-5882
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.6, 0.92.1
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Ashutosh Jindal
>         Attachments: HBASE-5882_v5.patch, hbase_5882.patch, hbase_5882_V2.patch, hbase_5882_V3.patch, hbase_5882_V4.patch
>
>
> Currently on  master restart if it tries to do processRIT, any region if found on dead server tries to avoid the nwe assignment so that timeout monitor can take care.
> This case is more prominent if the node is found in RS_ZK_REGION_OPENING state. I think we can handle this by triggering a new assignment with a new plan.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira