[jira] [Commented] (JENA-1478) DifferenceDatasetGraph.contains

["Andy Seaborne (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JENA-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352367#comment-16352367 ] 

Andy Seaborne commented on JENA-1478:
-------------------------------------

Found during some on-going work on transactions.
I can apply this change as part of that PR if the fix is agreed.


> DifferenceDatasetGraph.contains
> -------------------------------
>
>                 Key: JENA-1478
>                 URL: https://issues.apache.org/jira/browse/JENA-1478
>             Project: Apache Jena
>          Issue Type: Bug
>    Affects Versions: Jena 3.6.0
>            Reporter: Andy Seaborne
>            Priority: Major
>             Fix For: Jena 3.7.0
>
>
> (Assuming "difference is set-difference" not symmetric difference")
> defined "contains" as 
> {noformat}
> public boolean contains(Node g, Node s, Node p, Node o) {
>     return both(dsg -> dsg.contains(g, s, p, o));
> }
> {noformat}
> This should be:
> {noformat}
> public boolean contains(Node g, Node s, Node p, Node o) {
>     return getLeft().contains(g, s, p, o) && ! getRight().contains(g, s, p, o);
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)