[jira] [Commented] (CASSANDRA-20588) Fix single token batch atomicity with Accord/non-Accord batches by using the batch log

["David Capwell (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-20588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18077120#comment-18077120 ] 

David Capwell commented on CASSANDRA-20588:
-------------------------------------------

triaging a few test failures.  I don't think this patch could have caused them, but its in accord so need to look closer... should be able to merge today assuming the triage points out its not this patches fault

> Fix single token batch atomicity with Accord/non-Accord batches by using the batch log
> --------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-20588
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-20588
>             Project: Apache Cassandra
>          Issue Type: Bug
>          Components: Accord
>            Reporter: Ariel Weisberg
>            Assignee: Alan Wang
>            Priority: Normal
>             Fix For: NA
>
>         Attachments: ci_summary.html, result_details.tar.gz
>
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> Single token batches are currently 99% atomic without Accord because they are sent to a single node and can be applied to multiple tables out of the commit log reliably. Currently if that happens and one table is running on Accord and one is not then the batch will be split it into a Cassandra write and an Accord write and lose atomicity.
> The most straightforward fix is probably to route the entire batch through Accord if any of it touches an Accord table. It’s fine to use Accord to apply writes and this won’t impact the latency since Accord was being used anyways.
> This will require some modifications to TxnUpdate and maybe TxnWrite to allow the entire contents of the batch even for tables Accord isn’t managing to tag along and be applied at the same time as the involved Accord tables.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org