You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Johan Oskarsson (JIRA)" <ji...@apache.org> on 2007/10/12 17:46:50 UTC
[jira] Created: (HADOOP-2041) Add convenience put method that takes
writable
Add convenience put method that takes writable
----------------------------------------------
Key: HADOOP-2041
URL: https://issues.apache.org/jira/browse/HADOOP-2041
Project: Hadoop
Issue Type: Improvement
Components: contrib/hbase
Reporter: Johan Oskarsson
Priority: Trivial
It would be very useful to have a put method on HTable that takes a Writable instead of a byte array.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2041) Add convenience put method that takes
writable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HADOOP-2041:
--------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed. Resolving. Thanks for the patch Johan.
> Add convenience put method that takes writable
> ----------------------------------------------
>
> Key: HADOOP-2041
> URL: https://issues.apache.org/jira/browse/HADOOP-2041
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Trivial
> Fix For: 0.16.0
>
> Attachments: htable-putwritable-v2.patch
>
>
> It would be very useful to have a put method on HTable that takes a Writable instead of a byte array.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2041) Add convenience put method that
takes writable
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534930 ]
Hadoop QA commented on HADOOP-2041:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12367763/htable-putwritable-v2.patch
against trunk revision r584824.
@author +1. The patch does not contain any @author tags.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new compiler warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/945/testReport/
Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/945/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/945/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/945/console
This message is automatically generated.
> Add convenience put method that takes writable
> ----------------------------------------------
>
> Key: HADOOP-2041
> URL: https://issues.apache.org/jira/browse/HADOOP-2041
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Trivial
> Fix For: 0.16.0
>
> Attachments: htable-putwritable-v2.patch
>
>
> It would be very useful to have a put method on HTable that takes a Writable instead of a byte array.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2041) Add convenience put method that
takes writable
Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534428 ]
Johan Oskarsson commented on HADOOP-2041:
-----------------------------------------
That's exactly what I mean. I've got a simple patch ready to do that, but can't submit it until monday. If anyone of you guys want to do one yourselves before then, be my guest.
> Add convenience put method that takes writable
> ----------------------------------------------
>
> Key: HADOOP-2041
> URL: https://issues.apache.org/jira/browse/HADOOP-2041
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Trivial
>
> It would be very useful to have a put method on HTable that takes a Writable instead of a byte array.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2041) Add convenience put method that takes
writable
Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Oskarsson updated HADOOP-2041:
------------------------------------
Attachment: htable-putwritable-v2.patch
Mini patch to overload put to allow the user to pass a Writable instead of a byte array.
> Add convenience put method that takes writable
> ----------------------------------------------
>
> Key: HADOOP-2041
> URL: https://issues.apache.org/jira/browse/HADOOP-2041
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Trivial
> Fix For: 0.16.0
>
> Attachments: htable-putwritable-v2.patch
>
>
> It would be very useful to have a put method on HTable that takes a Writable instead of a byte array.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2041) Add convenience put method that takes
writable
Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Oskarsson updated HADOOP-2041:
------------------------------------
Fix Version/s: 0.16.0
Status: Patch Available (was: Open)
> Add convenience put method that takes writable
> ----------------------------------------------
>
> Key: HADOOP-2041
> URL: https://issues.apache.org/jira/browse/HADOOP-2041
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Trivial
> Fix For: 0.16.0
>
> Attachments: htable-putwritable-v2.patch
>
>
> It would be very useful to have a put method on HTable that takes a Writable instead of a byte array.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-2041) Add convenience put method that
takes writable
Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Oskarsson reassigned HADOOP-2041:
---------------------------------------
Assignee: Johan Oskarsson
> Add convenience put method that takes writable
> ----------------------------------------------
>
> Key: HADOOP-2041
> URL: https://issues.apache.org/jira/browse/HADOOP-2041
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Trivial
>
> It would be very useful to have a put method on HTable that takes a Writable instead of a byte array.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2041) Add convenience put method that
takes writable
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534367 ]
Jim Kellerman commented on HADOOP-2041:
---------------------------------------
Just to clarify the request, what I think you are proposing is adding:
public void put(long lockid, Text column, Writable val)
but you are not proposing to overload any of the get(...) methods or HScannerInterface.next
to return a Writable.
Overloading put is easy. Overloading get and next is hard because we currently do not store any type information for the value. All values are of type byte[]
If that is correct, then yes, we can add this in 0.16.0
> Add convenience put method that takes writable
> ----------------------------------------------
>
> Key: HADOOP-2041
> URL: https://issues.apache.org/jira/browse/HADOOP-2041
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Trivial
>
> It would be very useful to have a put method on HTable that takes a Writable instead of a byte array.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.