You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@netbeans.apache.org by borxa <gi...@git.apache.org> on 2017/10/01 17:04:59 UTC

[GitHub] incubator-netbeans pull request #32: [NETBEANS-54] Module Review server

GitHub user borxa opened a pull request:

    https://github.com/apache/incubator-netbeans/pull/32

    [NETBEANS-54] Module Review server

    - no external library
    - checked Rat report; changed license headers in 2 files
    - skimmed through the module, did not notice additional problems

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/borxa/incubator-netbeans master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-netbeans/pull/32.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #32
    
----
commit 664936aa2c6d60406818ef016052d36681efed00
Author: borxa <bo...@192.168.1.201>
Date:   2017-10-01T16:54:40Z

    [NETBEANS-54] Module Review server

----


---

[GitHub] incubator-netbeans issue #32: [NETBEANS-54] Module Review server

Posted by matthiasblaesing <gi...@git.apache.org>.

Github user matthiasblaesing commented on the issue:

    https://github.com/apache/incubator-netbeans/pull/32
  
    Thank you - I merged the changes into master with 2 positive reviews. I suggest, that you include the full name into the author field, user names look strange.
    
    The merge can be found here: https://github.com/apache/incubator-netbeans/commit/9a152a75f50f53219b3b2669b6ab9e69a9beb1d7
    
    Please close this PR yourself.


---

[GitHub] incubator-netbeans pull request #32: [NETBEANS-54] Module Review server

Posted by borxa <gi...@git.apache.org>.

Github user borxa closed the pull request at:

    https://github.com/apache/incubator-netbeans/pull/32


---

[GitHub] incubator-netbeans issue #32: [NETBEANS-54] Module Review server

Posted by borxa <gi...@git.apache.org>.

Github user borxa commented on the issue:

    https://github.com/apache/incubator-netbeans/pull/32
  
    Settings updated


---

[GitHub] incubator-netbeans issue #32: [NETBEANS-54] Module Review server

Posted by matthiasblaesing <gi...@git.apache.org>.

Github user matthiasblaesing commented on the issue:

    https://github.com/apache/incubator-netbeans/pull/32
  
    The changes itself look good. Could you please just adjust your git setttings to contain your name and email address as author (see here: https://www.git-tower.com/learn/git/faq/change-author-name-email).


---