You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "SYEDMDSAAD (via GitHub)" <gi...@apache.org> on 2026/02/18 18:58:36 UTC

[PR] GITHUB#15480 Deprecate SortField#setMissingValue and add migration test [lucene]

SYEDMDSAAD opened a new pull request, #15720:
URL: https://github.com/apache/lucene/pull/15720

   This change prepares SortField for immutability by deprecating setMissingValue and adding tests that ensure backward compatibility with the constructor-based approach.
   No behavior changes are introduced.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

Re: [PR] GITHUB#15480 Deprecate SortField#setMissingValue and add migration test [lucene]

Posted by "SYEDMDSAAD (via GitHub)" <gi...@apache.org>.
SYEDMDSAAD commented on PR #15720:
URL: https://github.com/apache/lucene/pull/15720#issuecomment-3925093875

   > Hi @SYEDMDSAAD , SortField.setMissingValue is already deprecated in 10.x and removed entirely in main.
   
   Thanks for the clarification!
   
   In that case, should this issue focus on making the remaining internal state of `SortField` immutable (e.g., final fields and preventing post-construction mutation), rather than deprecating the setter?
   
   I can investigate what parts of the class still allow mutation and propose a minimal change accordingly.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

Re: [PR] GITHUB#15480 Deprecate SortField#setMissingValue and add migration test [lucene]

Posted by "romseygeek (via GitHub)" <gi...@apache.org>.
romseygeek commented on PR #15720:
URL: https://github.com/apache/lucene/pull/15720#issuecomment-3925725358

   The main issue for that is https://github.com/apache/lucene/issues/15480, let's close this out and start from there?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

Re: [PR] GITHUB#15480 Deprecate SortField#setMissingValue and add migration test [lucene]

Posted by "romseygeek (via GitHub)" <gi...@apache.org>.
romseygeek commented on PR #15720:
URL: https://github.com/apache/lucene/pull/15720#issuecomment-3922840770

   Hi @SYEDMDSAAD , SortField.setMissingValue is already deprecated in 10.x and removed entirely in main.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

Re: [PR] GITHUB#15480 Deprecate SortField#setMissingValue and add migration test [lucene]

Posted by "SYEDMDSAAD (via GitHub)" <gi...@apache.org>.
SYEDMDSAAD commented on PR #15720:
URL: https://github.com/apache/lucene/pull/15720#issuecomment-3927070462

   > The main issue for that is #15480, let's close this out and start from there?
   
   Yeah sure!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

Re: [PR] GITHUB#15480 Deprecate SortField#setMissingValue and add migration test [lucene]

Posted by "romseygeek (via GitHub)" <gi...@apache.org>.
romseygeek closed pull request #15720: GITHUB#15480 Deprecate SortField#setMissingValue and add migration test
URL: https://github.com/apache/lucene/pull/15720


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org