Re: [PR] Fix `EksPodOperator` in deferrable mode [airflow]

["vincbeck (via GitHub)" <gi...@apache.org>]

vincbeck commented on code in PR #51255:
URL: https://github.com/apache/airflow/pull/51255#discussion_r2121206460


##########
providers/amazon/src/airflow/providers/amazon/aws/operators/eks.py:
##########
@@ -1072,3 +1073,15 @@ def execute(self, context: Context):
             eks_cluster_name=self.cluster_name, pod_namespace=self.namespace
         ) as self.config_file:
             return super().execute(context)
+
+    def trigger_reentry(self, context: Context, event: dict[str, Any]) -> Any:

Review Comment:
   >How many times will this be run? Just once once the we've resumed from the trigger?
   
   Correct
   
   > Also, this is the first time I'm seeing it, what's the difference between trigger_reentry and execute_complete?
   
   The name of the function is passed as parameter when you call `self.defer`, it is totally up to the author of the operator to use whatever name they see fit. Usually we use `execution_complete`, but again, just a convention :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org