You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/05/19 18:16:44 UTC

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6936: Add SERVER_PROCESSING and NETTY_CONNECTION to broker query phase metrics

jackjlli commented on a change in pull request #6936:
URL: https://github.com/apache/incubator-pinot/pull/6936#discussion_r635478989



##########
File path: pinot-common/src/main/java/org/apache/pinot/common/metrics/BrokerQueryPhase.java
##########
@@ -30,6 +30,8 @@
   QUERY_EXECUTION,
   QUERY_ROUTING,
   SCATTER_GATHER,
+  SERVER_PROCESSING,

Review comment:
       The primary aim for this PR is to extract the time spent on netty from the time spent on scatter_gather. We should have a metric to actually measure the network time. Now that the broker query phase has all the phases from end to end, it'd be good to have the server total query time here instead of leaving it to the server metrics.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org