You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/03/06 08:32:19 UTC
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6499: [Incompatible Enhancement]New index policy of ElasticSearch storage option
codecov[bot] edited a comment on pull request #6499:
URL: https://github.com/apache/skywalking/pull/6499#issuecomment-791878535
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6499?src=pr&el=h1) Report
> Merging [#6499](https://codecov.io/gh/apache/skywalking/pull/6499?src=pr&el=desc) (eae7076) into [master](https://codecov.io/gh/apache/skywalking/commit/1b8fdd5688df48ce593e2b4b664c7eaf90078d36?el=desc) (1b8fdd5) will **decrease** coverage by `4.55%`.
> The diff coverage is `48.46%`.
[](https://codecov.io/gh/apache/skywalking/pull/6499?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6499 +/- ##
============================================
- Coverage 58.24% 53.69% -4.56%
+ Complexity 4090 3861 -229
============================================
Files 996 990 -6
Lines 24584 24718 +134
Branches 2387 2404 +17
============================================
- Hits 14320 13272 -1048
- Misses 9015 10275 +1260
+ Partials 1249 1171 -78
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6499?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6499/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==) | `33.33% <0.00%> (-66.67%)` | `1.00 <0.00> (-1.00)` | |
| [...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6499/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==) | `100.00% <ø> (ø)` | `5.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6499/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `3.70% <0.00%> (-1.86%)` | `1.00 <0.00> (ø)` | |
| [...ge/plugin/elasticsearch/query/AlarmQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6499/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWxhcm1RdWVyeUVzREFPLmphdmE=) | `7.14% <0.00%> (-0.27%)` | `1.00 <0.00> (ø)` | |
| [...ugin/elasticsearch/query/BrowserLogQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6499/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQnJvd3NlckxvZ1F1ZXJ5RXNEQU8uamF2YQ==) | `6.06% <0.00%> (-47.07%)` | `1.00 <0.00> (-2.00)` | |
| [...ge/plugin/elasticsearch/query/ESEventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6499/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvRVNFdmVudFF1ZXJ5REFPLmphdmE=) | `3.44% <0.00%> (-56.56%)` | `1.00 <0.00> (-3.00)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6499/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.04% <0.00%> (-86.96%)` | `1.00 <0.00> (-3.00)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6499/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-89.98%)` | `1.00 <0.00> (-10.00)` | |
| [...gin/elasticsearch/query/TopNRecordsQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6499/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVG9wTlJlY29yZHNRdWVyeUVzREFPLmphdmE=) | `8.00% <0.00%> (-0.34%)` | `1.00 <0.00> (ø)` | |
| [...orage/plugin/elasticsearch7/dao/MetricsEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6499/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9kYW8vTWV0cmljc0VzN0RBTy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (-1.00)` | |
| ... and [144 more](https://codecov.io/gh/apache/skywalking/pull/6499/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6499?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6499?src=pr&el=footer). Last update [1b8fdd5...eae7076](https://codecov.io/gh/apache/skywalking/pull/6499?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org