[GitHub] [cassandra] spodkowinski commented on a change in pull request #1313: CASSANDRA-17130: Log missing peers in StartupClusterConnectivityChecker

[GitBox <gi...@apache.org>]

spodkowinski commented on a change in pull request #1313:
URL: https://github.com/apache/cassandra/pull/1313#discussion_r746356976



##########
File path: src/java/org/apache/cassandra/net/StartupClusterConnectivityChecker.java
##########
@@ -118,7 +121,7 @@ public boolean execute(Set<InetAddressAndPort> peers, Function<InetAddressAndPor
                         TimeUnit.NANOSECONDS.toSeconds(timeoutNanos));
         }
 
-        AckMap acks = new AckMap(3);
+        AckMap acks = new AckMap(3, peers);

Review comment:
       Why would 3 be the correct value to use here? Not part of the change set, but can you please add a code comment?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org