You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "Hisoka-X (via GitHub)" <gi...@apache.org> on 2023/08/05 03:04:23 UTC
[GitHub] [spark] Hisoka-X opened a new pull request, #42356: [SPARK-44685][SQL] Remove deprecated Catalog#createExternalTable
Hisoka-X opened a new pull request, #42356:
URL: https://github.com/apache/spark/pull/42356
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Since we deprecated `Catalog#createExternalTable` in 2.2.0, I think it's a good time to remove it on 4.0.0
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
Remove deprecated code.
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
Yes, the deprecated method can't be used.
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
exist test.
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42356: [SPARK-44685][SQL] Remove deprecated Catalog#createExternalTable
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #42356:
URL: https://github.com/apache/spark/pull/42356#discussion_r1285288659
##########
R/pkg/NAMESPACE:
##########
@@ -485,7 +485,6 @@ export("as.DataFrame",
"cacheTable",
"clearCache",
"createDataFrame",
- "createExternalTable",
Review Comment:
Oh I apologize that I forgot we already discussed that the next Spark version would likely be 4.0.0 - my bad.
My concern is mainly about "Considerations when breaking APIs" at https://spark.apache.org/versioning-policy.html. We discussed about removing some of deprecated API including `SQLContext` at Spark 3.0.0 but we did not remove in the end because it might be too breaking changes. At that time, we had to remove and revert some of those PRs (see also https://github.com/apache/spark/pull/22843 and https://github.com/apache/spark/pull/27815) - this includes `createExternalTable`.
I personally would like to have a bit of discussion in the mailing list (probably after 3.5.0 release) before we remove some, and find out that some of them are too much breaking changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #42356: [SPARK-44685][SQL] Remove deprecated Catalog#createExternalTable
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #42356:
URL: https://github.com/apache/spark/pull/42356#issuecomment-1666688194
Tag the JIRA with `release-notes` and add the same release notes to the "Docs text" field you can see when you Edit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-44685][SQL] Remove deprecated Catalog#createExternalTable [spark]
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on PR #42356:
URL: https://github.com/apache/spark/pull/42356#issuecomment-1831790628
> > > We should only remove an API if there is clear evidence showing that no one is using it.
> >
> >
> > Thanks, I will open a discussion in the mailing list after 3.5.0 released.
>
> @Hisoka-X Will you still initiate this discussion?
I think @srowen already open a discussion in https://lists.apache.org/thread/yf2wvypvkqk7rqtv4s641ygbk4gr3tc2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-44685][SQL] Remove deprecated Catalog#createExternalTable [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42356:
URL: https://github.com/apache/spark/pull/42356#issuecomment-1813504669
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Hisoka-X commented on pull request #42356: [SPARK-44685][SQL] Remove deprecated Catalog#createExternalTable
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on PR #42356:
URL: https://github.com/apache/spark/pull/42356#issuecomment-1667084504
> We should only remove an API if there is clear evidence showing that no one is using it.
Thanks, I will open a discussion in the mailing list after 3.5.0 released.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #42356: [SPARK-44685][SQL] Remove deprecated Catalog#createExternalTable
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #42356:
URL: https://github.com/apache/spark/pull/42356#issuecomment-1666527360
This needs an update to the release notes and migration guide. This should also be in the JIRA - release-notes and text of release note
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42356: [SPARK-44685][SQL] Remove deprecated Catalog#createExternalTable
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #42356:
URL: https://github.com/apache/spark/pull/42356#discussion_r1285288659
##########
R/pkg/NAMESPACE:
##########
@@ -485,7 +485,6 @@ export("as.DataFrame",
"cacheTable",
"clearCache",
"createDataFrame",
- "createExternalTable",
Review Comment:
Oh I apologize that I forgot we already discussed that the next Spark version would likely be 4.0.0 - my bad.
My concern is mainly about "Considerations when breaking APIs" at https://spark.apache.org/versioning-policy.html. We discussed about removing some of deprecated API including `SQLContext` at Spark 3.0.0 but we did not remove in the end because it might be too breaking changes. At that time, we had to remove and revert some of those PRs (see also https://github.com/apache/spark/pull/22843 and https://github.com/apache/spark/pull/27815).
I personally would like to have a bit of discussion in the mailing list (probably after 3.5.0 release) before we remove some, and find out that some of them are too much breaking changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-44685][SQL] Remove deprecated Catalog#createExternalTable [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #42356:
URL: https://github.com/apache/spark/pull/42356#issuecomment-1831418085
> > We should only remove an API if there is clear evidence showing that no one is using it.
>
> Thanks, I will open a discussion in the mailing list after 3.5.0 released.
@Hisoka-X Will you still initiate this discussion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Hisoka-X commented on pull request #42356: [SPARK-44685][SQL] Remove deprecated Catalog#createExternalTable
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on PR #42356:
URL: https://github.com/apache/spark/pull/42356#issuecomment-1666691743
> Tag the JIRA with `release-notes` and add the same release notes to the "Docs text" field you can see when you Edit
Done. Thanks for your guidance!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a diff in pull request #42356: [SPARK-44685][SQL] Remove deprecated Catalog#createExternalTable
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on code in PR #42356:
URL: https://github.com/apache/spark/pull/42356#discussion_r1285282846
##########
R/pkg/NAMESPACE:
##########
@@ -485,7 +485,6 @@ export("as.DataFrame",
"cacheTable",
"clearCache",
"createDataFrame",
- "createExternalTable",
Review Comment:
Certainly, there may be an argument to not remove some methods. But these can only be removed at major versions; removing one does not imply all deprecated methods must be removed, either. What do you mean by 'going for 4.0.0' and how does this relate to SQLContext? there is indeed not one single plan for all deprecated methods, but what is the argument against this particular one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Hisoka-X commented on pull request #42356: [SPARK-44685][SQL] Remove deprecated Catalog#createExternalTable
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on PR #42356:
URL: https://github.com/apache/spark/pull/42356#issuecomment-1666681003
> needs an update to the release notes
> This needs an update to the release notes and migration guide. This should also be in the JIRA - release-notes and text of release note
Hi @srowen , thanks for review. I already add it into migration guide. But I have some problem about update to the release notes and JIRA, I don't know how to do this, is only need change affect version to 4.0.0? Can you tell me more? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #42356: [SPARK-44685][SQL] Remove deprecated Catalog#createExternalTable
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #42356:
URL: https://github.com/apache/spark/pull/42356#issuecomment-1667067292
We should only remove an API if there is clear evidence showing that no one is using it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-44685][SQL] Remove deprecated Catalog#createExternalTable [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #42356: [SPARK-44685][SQL] Remove deprecated Catalog#createExternalTable
URL: https://github.com/apache/spark/pull/42356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42356: [SPARK-44685][SQL] Remove deprecated Catalog#createExternalTable
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #42356:
URL: https://github.com/apache/spark/pull/42356#discussion_r1285280354
##########
R/pkg/NAMESPACE:
##########
@@ -485,7 +485,6 @@ export("as.DataFrame",
"cacheTable",
"clearCache",
"createDataFrame",
- "createExternalTable",
Review Comment:
Hmm .. I wouldn't remove it for now. We have a bunch of deprecated API, and we don't have an explicit plan to how to handle them, and we're not even sure if we're actually going for 4.0.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42356: [SPARK-44685][SQL] Remove deprecated Catalog#createExternalTable
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #42356:
URL: https://github.com/apache/spark/pull/42356#discussion_r1285280612
##########
R/pkg/NAMESPACE:
##########
@@ -485,7 +485,6 @@ export("as.DataFrame",
"cacheTable",
"clearCache",
"createDataFrame",
- "createExternalTable",
Review Comment:
For example, if we apply the same argument, we should also remove `SQLContext`, etc., etc that would be largely a breaking change, which I believe can be controversial.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a diff in pull request #42356: [SPARK-44685][SQL] Remove deprecated Catalog#createExternalTable
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on code in PR #42356:
URL: https://github.com/apache/spark/pull/42356#discussion_r1285289400
##########
R/pkg/NAMESPACE:
##########
@@ -485,7 +485,6 @@ export("as.DataFrame",
"cacheTable",
"clearCache",
"createDataFrame",
- "createExternalTable",
Review Comment:
Yeah I think it's fair to hold for a more joined up discussion of what should be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #42356: [SPARK-44685][SQL] Remove deprecated Catalog#createExternalTable
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #42356:
URL: https://github.com/apache/spark/pull/42356#issuecomment-1667230130
Set this pr to draft to avoid accidental merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-44685][SQL] Remove deprecated Catalog#createExternalTable [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #42356:
URL: https://github.com/apache/spark/pull/42356#issuecomment-1831874765
> > > > We should only remove an API if there is clear evidence showing that no one is using it.
> > >
> > >
> > > Thanks, I will open a discussion in the mailing list after 3.5.0 released.
> >
> >
> > @Hisoka-X Will you still initiate this discussion?
>
> I think @srowen already open a discussion in https://lists.apache.org/thread/yf2wvypvkqk7rqtv4s641ygbk4gr3tc2
OK, I see, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org