You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Dan Smith <ds...@pivotal.io> on 2016/03/31 02:58:30 UTC
Review Request 45515: GEODE-1123: Exclude the locator in
StreamingOperationManyDUnitTest
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45515/
-----------------------------------------------------------
Review request for geode and Bruce Schuchardt.
Repository: geode
Description
-------
This test was calling getOtherDistributionManagerIds, which included
that locator. There seemed to be some race where the test would pass and
find 4 other members, rather than the locator, but if I added a sleep,
the test would always fail.
The test now doesn't use getOtherDistributionManagerIds at all.
It's still not clear to me if something changed to make this test fail more frequently now - it's pretty weird that there is a race with this method because the test synchronously started a DS in all of the members. But maybe some notification was still pending when the getOtherDistributionManagerIds was called.
Diffs
-----
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/streaming/StreamingOperationManyDUnitTest.java 91e5e2056e2712b1cc22f36fe34568f7392bac43
Diff: https://reviews.apache.org/r/45515/diff/
Testing
-------
Thanks,
Dan Smith
Re: Review Request 45515: GEODE-1123: Exclude the locator in
StreamingOperationManyDUnitTest
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45515/#review126317
-----------------------------------------------------------
Ship it!
Ship It!
- Bruce Schuchardt
On March 31, 2016, 12:58 a.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45515/
> -----------------------------------------------------------
>
> (Updated March 31, 2016, 12:58 a.m.)
>
>
> Review request for geode and Bruce Schuchardt.
>
>
> Repository: geode
>
>
> Description
> -------
>
> This test was calling getOtherDistributionManagerIds, which included
> that locator. There seemed to be some race where the test would pass and
> find 4 other members, rather than the locator, but if I added a sleep,
> the test would always fail.
>
> The test now doesn't use getOtherDistributionManagerIds at all.
>
> It's still not clear to me if something changed to make this test fail more frequently now - it's pretty weird that there is a race with this method because the test synchronously started a DS in all of the members. But maybe some notification was still pending when the getOtherDistributionManagerIds was called.
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/streaming/StreamingOperationManyDUnitTest.java 91e5e2056e2712b1cc22f36fe34568f7392bac43
>
> Diff: https://reviews.apache.org/r/45515/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>