[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct

[GitBox <gi...@apache.org>]

kishoreg commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct
URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r291385532
 
 

 ##########
 File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/InPredicateAstNode.java
 ##########
 @@ -92,7 +95,7 @@ public FilterQueryTree buildFilterQueryTree() {
       throw new Pql2CompilationException("IN predicate has no identifier");
     }
 
-    Set<String> values = new HashSet<>();
+    List<String> values = new ArrayList<>();
 
 Review comment:
   I want to maintain order so that we can compare the old and new broker request. If deduping is needed, we can use LinkedHashSet

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org