You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2018/01/19 17:36:29 UTC

[GitHub] flink pull request #5319: [FLINK-8463] [rest] Remove blocking of IO executor...

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/5319

    [FLINK-8463] [rest] Remove blocking of IO executor in RestClient#submitRequest

    ## What is the purpose of the change
    
    Instead of waiting on the ChannelFuture we register a ChannelFutureListener which
    is notified when the channel has been established. This unblocks IO executor threads
    in the RestClient.
    
    
    ## Verifying this change
    
    This change is already covered by existing tests.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink removeRestClientBlocking

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5319.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5319
    
----
commit bb0032ff74aa71b3e2f8be9bc201a00e28551280
Author: Till Rohrmann <tr...@...>
Date:   2018-01-19T17:27:22Z

    [FLINK-8463] [rest] Remove blocking of IO executor in RestClient#submitRequest
    
    Instead of waiting on the ChannelFuture we register a ChannelFutureListener which
    is notified when the channel has been established. This unblocks IO executor threads
    in the RestClient.

----


---

[GitHub] flink pull request #5319: [FLINK-8463] [rest] Remove blocking of IO executor...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5319


---

[GitHub] flink issue #5319: [FLINK-8463] [rest] Remove blocking of IO executor in Res...

Posted by tillrohrmann <gi...@git.apache.org>.

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/5319
  
    Thanks for the review @GJL. Merging this PR.


---

[GitHub] flink issue #5319: [FLINK-8463] [rest] Remove blocking of IO executor in Res...

Posted by GJL <gi...@git.apache.org>.

Github user GJL commented on the issue:

    https://github.com/apache/flink/pull/5319
  
    💯 


---