[jira] [Commented] (AMQ-5350) Separate the AMQP maxFrameSize setting from the WireFormat maxFrameSize setting.

["clebert suconic (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMQ-5350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14127117#comment-14127117 ] 

clebert suconic commented on AMQ-5350:
--------------------------------------

do you still set maxFrameSize on the transport?


I found out that not setting it at all will make performance to be 10X better due to some issues on Proton. It's a bug on Proton probably and still not fixed.

> Separate the AMQP maxFrameSize setting from the WireFormat maxFrameSize setting.
> --------------------------------------------------------------------------------
>
>                 Key: AMQ-5350
>                 URL: https://issues.apache.org/jira/browse/AMQ-5350
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: AMQP
>    Affects Versions: 5.10.0
>            Reporter: Timothy Bish
>            Assignee: Timothy Bish
>            Priority: Minor
>             Fix For: 5.11.0
>
>
> We currently set the maxFrameSize value in Proton using the WireFormat maxFrameSize value.  This not the correct application of this property as it is meant to control the max size a frame we will accept before we disconnect a client whereas in AMQP this control how large a frame is before the transport starts splitting the data into multiple frames.  
> Setting this value on Proton has other side effects like increased memory utilization and decreased performance.  Instead of linking these we should introduce an additional property on the AMQP WireFormat class to allow for setting the maxAmqpFrameSize which defaults to no max.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)