You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/06/03 18:50:52 UTC

[GitHub] [beam] aaltay commented on a change in pull request #14671: [BEAM-12244] Use GRPC insecure_channel in expansion service

aaltay commented on a change in pull request #14671:
URL: https://github.com/apache/beam/pull/14671#discussion_r645048419



##########
File path: sdks/python/apache_beam/transforms/external.py
##########
@@ -319,25 +319,9 @@ def _service(self):
     if isinstance(self._expansion_service, str):
       channel_options = [("grpc.max_receive_message_length", -1),
                          ("grpc.max_send_message_length", -1)]
-      if hasattr(grpc, 'local_channel_credentials'):
-        # Some environments may not support insecure channels. Hence use a
-        # secure channel with local credentials here.

Review comment:
       @nirga - Do you know the answer? I think the suggestion to use fallback mechanism is a good one.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org