You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by ravicodder <gi...@git.apache.org> on 2016/02/04 07:31:04 UTC
[GitHub] incubator-zeppelin pull request: Add selenium test case for show a...
GitHub user ravicodder opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/692
Add selenium test case for show and hide title of paragraph
What is this PR for?
Add a new test case for testing the show title and hide title button.
What type of PR is it?
Test
Is there a relevant Jira issue?
NA
How should this be tested?
On OSX, you'll need firefox 42.0 installed, then you can run with
PATH=~/Applications/Firefox.app/Contents/MacOS/:$PATH CI="" \
mvn -Dtest=org.apache.zeppelin.ParagraphActionsIT -Denforcer.skip=true \
test -pl zeppelin-server
Questions:
Does the licenses files need update?NO
Is there breaking changes for older versions?NO
Does this needs documentation?NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ravicodder/incubator-zeppelin testTitleButton
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/692.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #692
----
commit 14c84488def86fd1abcbbc49cc02d3a708cbf536
Author: Ravi Ranjan <ra...@gmail.com>
Date: 2016-02-03T05:51:26Z
Add selenium test case for show and hide title of paragraph
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add selenium test case for show a...
Posted by ravicodder <gi...@git.apache.org>.
Github user ravicodder commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/692#issuecomment-187559272
@corneadoug Thank you for pointing it out. Changes done, please have a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add selenium test case for show a...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/692
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add selenium test case for show a...
Posted by ravicodder <gi...@git.apache.org>.
Github user ravicodder commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/692#issuecomment-192393131
@felixcheung done rebase.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add selenium test case for show a...
Posted by ravicodder <gi...@git.apache.org>.
Github user ravicodder commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/692#issuecomment-187133518
@felixcheung
@prabhjyotsingh
Used handle exception please have a look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add selenium test case for show a...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/692#issuecomment-185509350
Error:
```
09:55:34,147 ERROR org.apache.zeppelin.integration.ZeppelinIT:257 - Exception in ZeppelinIT while testSparkInterpreterDependencyLoading
org.openqa.selenium.TimeoutException: Timed out after 60 seconds waiting for org.apache.zeppelin.AbstractZeppelinIT$1@3d56054b
```
Could you check?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add selenium test case for show a...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/692#issuecomment-193590836
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add selenium test case for show a...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/692#issuecomment-187305812
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add selenium test case for show a...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/692#issuecomment-192082260
@ravicodder could you rebase please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add selenium test case for show a...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/692#issuecomment-185041682
@ravicodder can you please rebase again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add selenium test case for show a...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/692#issuecomment-187324633
When you use multiple times the same XPath, it would be better to have a reusable variable for it.
This Xpath for the title `//div[contains(@class, 'binding')]` might not be precise enough. This is targeting the title a bit more: `//div[contains(@class, 'title')]/div`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add selenium test case for show a...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/692#issuecomment-184973699
@prabhjyotsingh could you review this as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---