You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by vladimir-kotikov <gi...@git.apache.org> on 2016/01/28 12:39:34 UTC
[GitHub] cordova-windows pull request: CB-10303 Add tests to cover argument...
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-windows/pull/145
CB-10303 Add tests to cover arguments parsing regression
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-windows CB-10303
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/145.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #145
----
commit ecb57e6ee6802a2650e550919692680e0101c8f6
Author: Vladimir Kotikov <ko...@gmail.com>
Date: 2016-01-28T10:53:20Z
Refactor tests:
Use jamine spies instead of rewire in most cases
Do not stub console log to simplify debug
commit 03324a000164c2a07dcf00acca19d97867c09124
Author: Vladimir Kotikov <ko...@gmail.com>
Date: 2016-01-28T11:36:51Z
CB-10303 Adds tests to cover arguments parsing regression
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10303 Add tests to cover argument...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/145
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10303 Add tests to cover argument...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/145#issuecomment-176142684
@nikhilkh, could you please take a look, when possible
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org