You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by li...@apache.org on 2018/09/16 03:06:13 UTC
spark git commit: [SPARK-25439][TESTS][SQL] Fixes TPCHQuerySuite
datatype of customer.c_nationkey to BIGINT according to spec
Repository: spark
Updated Branches:
refs/heads/master fefaa3c30 -> 02c2963f8
[SPARK-25439][TESTS][SQL] Fixes TPCHQuerySuite datatype of customer.c_nationkey to BIGINT according to spec
## What changes were proposed in this pull request?
Fixes TPCH DDL datatype of `customer.c_nationkey` from `STRING` to `BIGINT` according to spec and `nation.nationkey` in `TPCHQuerySuite.scala`. The rest of the keys are OK.
Note, this will lead to **non-comparable previous results** to new runs involving the customer table.
## How was this patch tested?
Manual tests
Author: npoggi <np...@gmail.com>
Closes #22430 from npoggi/SPARK-25439_Fix-TPCH-customer-c_nationkey.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/02c2963f
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/02c2963f
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/02c2963f
Branch: refs/heads/master
Commit: 02c2963f895b9d78d7f6d9972cacec4ef55fa278
Parents: fefaa3c
Author: npoggi <np...@gmail.com>
Authored: Sat Sep 15 20:06:08 2018 -0700
Committer: gatorsmile <ga...@gmail.com>
Committed: Sat Sep 15 20:06:08 2018 -0700
----------------------------------------------------------------------
sql/core/src/test/scala/org/apache/spark/sql/TPCHQuerySuite.scala | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/02c2963f/sql/core/src/test/scala/org/apache/spark/sql/TPCHQuerySuite.scala
----------------------------------------------------------------------
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/TPCHQuerySuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/TPCHQuerySuite.scala
index e3e7005..b32d95d 100644
--- a/sql/core/src/test/scala/org/apache/spark/sql/TPCHQuerySuite.scala
+++ b/sql/core/src/test/scala/org/apache/spark/sql/TPCHQuerySuite.scala
@@ -69,7 +69,7 @@ class TPCHQuerySuite extends BenchmarkQueryTest {
sql(
"""
|CREATE TABLE `customer` (`c_custkey` BIGINT, `c_name` STRING, `c_address` STRING,
- |`c_nationkey` STRING, `c_phone` STRING, `c_acctbal` DECIMAL(10,0),
+ |`c_nationkey` BIGINT, `c_phone` STRING, `c_acctbal` DECIMAL(10,0),
|`c_mktsegment` STRING, `c_comment` STRING)
|USING parquet
""".stripMargin)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org