You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Vasily Zakharov (JIRA)" <ji...@apache.org> on 2007/07/31 01:59:52 UTC
[jira] Created: (HARMONY-4575) [classlib][swing][html] Images in
links are not working properly
[classlib][swing][html] Images in links are not working properly
----------------------------------------------------------------
Key: HARMONY-4575
URL: https://issues.apache.org/jira/browse/HARMONY-4575
Project: Harmony
Issue Type: Bug
Components: Classlib
Reporter: Vasily Zakharov
Attachments: test.zip
If an image is put inside an <a href=""> and </a> tags, it's not working as a part of the link - it's not clickable and mouse cursor doesn't change shape over it.
To reproduce, unpack the attached test.zip file and run 'java Test'. Then try moving the mouse over the image and clicking. Compare to moving mouse over and clicking the text besides the image.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-4575) [classlib][swing][html] Images in
links are not working properly
Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Petrenko resolved HARMONY-4575.
--------------------------------------
Resolution: Fixed
The patch has been applied.
Please verify.
> [classlib][swing][html] Images in links are not working properly
> ----------------------------------------------------------------
>
> Key: HARMONY-4575
> URL: https://issues.apache.org/jira/browse/HARMONY-4575
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Vasily Zakharov
> Assignee: Alexey Petrenko
> Attachments: H4575-ImageView-HTMLDocument.patch, test.zip
>
>
> If an image is put inside an <a href=""> and </a> tags, it's not working as a part of the link - it's not clickable and mouse cursor doesn't change shape over it.
> To reproduce, unpack the attached test.zip file and run 'java Test'. Then try moving the mouse over the image and clicking. Compare to moving mouse over and clicking the text besides the image.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4575) [classlib][swing][html] Images in
links are not working properly
Posted by "Vasily Zakharov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vasily Zakharov updated HARMONY-4575:
-------------------------------------
Attachment: (was: H4575-ImageView-HTMLDocument.patch)
> [classlib][swing][html] Images in links are not working properly
> ----------------------------------------------------------------
>
> Key: HARMONY-4575
> URL: https://issues.apache.org/jira/browse/HARMONY-4575
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Vasily Zakharov
> Assignee: Alexey Petrenko
> Attachments: H4575-ImageView-HTMLDocument.patch, test.zip
>
>
> If an image is put inside an <a href=""> and </a> tags, it's not working as a part of the link - it's not clickable and mouse cursor doesn't change shape over it.
> To reproduce, unpack the attached test.zip file and run 'java Test'. Then try moving the mouse over the image and clicking. Compare to moving mouse over and clicking the text besides the image.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4575) [classlib][swing][html] Images in
links are not working properly
Posted by "Vasily Zakharov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vasily Zakharov updated HARMONY-4575:
-------------------------------------
Attachment: (was: H4575-ImageView-HTMLDocument.patch)
> [classlib][swing][html] Images in links are not working properly
> ----------------------------------------------------------------
>
> Key: HARMONY-4575
> URL: https://issues.apache.org/jira/browse/HARMONY-4575
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Vasily Zakharov
> Assignee: Alexey Petrenko
> Attachments: H4575-ImageView-HTMLDocument.patch, test.zip
>
>
> If an image is put inside an <a href=""> and </a> tags, it's not working as a part of the link - it's not clickable and mouse cursor doesn't change shape over it.
> To reproduce, unpack the attached test.zip file and run 'java Test'. Then try moving the mouse over the image and clicking. Compare to moving mouse over and clicking the text besides the image.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4575) [classlib][swing][html] Images in
links are not working properly
Posted by "Vasily Zakharov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vasily Zakharov updated HARMONY-4575:
-------------------------------------
Attachment: (was: H4575-ImageView-HTMLDocument.patch)
> [classlib][swing][html] Images in links are not working properly
> ----------------------------------------------------------------
>
> Key: HARMONY-4575
> URL: https://issues.apache.org/jira/browse/HARMONY-4575
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Vasily Zakharov
> Assignee: Alexey Petrenko
> Attachments: H4575-ImageView-HTMLDocument.patch, test.zip
>
>
> If an image is put inside an <a href=""> and </a> tags, it's not working as a part of the link - it's not clickable and mouse cursor doesn't change shape over it.
> To reproduce, unpack the attached test.zip file and run 'java Test'. Then try moving the mouse over the image and clicking. Compare to moving mouse over and clicking the text besides the image.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-4575) [classlib][swing][html] Images in
links are not working properly
Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523533 ]
Dmitry Irlyanov commented on HARMONY-4575:
------------------------------------------
Vasily,
I've already created HARMONY-4694 and HARMONY-4692
> [classlib][swing][html] Images in links are not working properly
> ----------------------------------------------------------------
>
> Key: HARMONY-4575
> URL: https://issues.apache.org/jira/browse/HARMONY-4575
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Vasily Zakharov
> Assignee: Alexey Petrenko
> Attachments: H4575-ImageView-HTMLDocument.patch, test.zip
>
>
> If an image is put inside an <a href=""> and </a> tags, it's not working as a part of the link - it's not clickable and mouse cursor doesn't change shape over it.
> To reproduce, unpack the attached test.zip file and run 'java Test'. Then try moving the mouse over the image and clicking. Compare to moving mouse over and clicking the text besides the image.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4575) [classlib][swing][html] Images in
links are not working properly
Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Irlyanov updated HARMONY-4575:
-------------------------------------
Attachment: H4575-ImageView-HTMLDocument.patch
Proposed fix
> [classlib][swing][html] Images in links are not working properly
> ----------------------------------------------------------------
>
> Key: HARMONY-4575
> URL: https://issues.apache.org/jira/browse/HARMONY-4575
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Vasily Zakharov
> Attachments: H4575-ImageView-HTMLDocument.patch, test.zip
>
>
> If an image is put inside an <a href=""> and </a> tags, it's not working as a part of the link - it's not clickable and mouse cursor doesn't change shape over it.
> To reproduce, unpack the attached test.zip file and run 'java Test'. Then try moving the mouse over the image and clicking. Compare to moving mouse over and clicking the text besides the image.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-4575) [classlib][swing][html] Images in
links are not working properly
Posted by "Vasily Zakharov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12516578 ]
Vasily Zakharov commented on HARMONY-4575:
------------------------------------------
Note that if a link consists only of image, a clickable underscore is rendered to the right of the image (see HARMONY-4574).
> [classlib][swing][html] Images in links are not working properly
> ----------------------------------------------------------------
>
> Key: HARMONY-4575
> URL: https://issues.apache.org/jira/browse/HARMONY-4575
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Vasily Zakharov
> Attachments: test.zip
>
>
> If an image is put inside an <a href=""> and </a> tags, it's not working as a part of the link - it's not clickable and mouse cursor doesn't change shape over it.
> To reproduce, unpack the attached test.zip file and run 'java Test'. Then try moving the mouse over the image and clicking. Compare to moving mouse over and clicking the text besides the image.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-4575) [classlib][swing][html] Images in
links are not working properly
Posted by "Alexey A. Ivanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523482 ]
Alexey A. Ivanov commented on HARMONY-4575:
-------------------------------------------
Additionally,
HTML attributes border, hspace, vspace could be converted to CSS in StyleSheet.translateHTMLToCSS(AttributeSet).
This method isn't described in JavaDoc and I guess it is not fully implemented. However, it's used to convert HTML attributes to CSS ones so that Views could care for CSS only. You can add attribute conversions to there when applicable.
> [classlib][swing][html] Images in links are not working properly
> ----------------------------------------------------------------
>
> Key: HARMONY-4575
> URL: https://issues.apache.org/jira/browse/HARMONY-4575
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Vasily Zakharov
> Assignee: Alexey Petrenko
> Attachments: H4575-ImageView-HTMLDocument.patch, test.zip
>
>
> If an image is put inside an <a href=""> and </a> tags, it's not working as a part of the link - it's not clickable and mouse cursor doesn't change shape over it.
> To reproduce, unpack the attached test.zip file and run 'java Test'. Then try moving the mouse over the image and clicking. Compare to moving mouse over and clicking the text besides the image.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-4575) [classlib][swing][html] Images in
links are not working properly
Posted by "Alexey A. Ivanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523477 ]
Alexey A. Ivanov commented on HARMONY-4575:
-------------------------------------------
One small comment to the fix,
I propose to move attribute setting from constructor to setPropertiesFromAttributes() because attributes of a View can be updated after view has been created. And no cached attributes will be updated if attribute adjustment is performed in constructor. To solve this problem you just need to move it to setPropertiesFromAttributes() method.
Regards,
Alexey.
> [classlib][swing][html] Images in links are not working properly
> ----------------------------------------------------------------
>
> Key: HARMONY-4575
> URL: https://issues.apache.org/jira/browse/HARMONY-4575
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Vasily Zakharov
> Assignee: Alexey Petrenko
> Attachments: H4575-ImageView-HTMLDocument.patch, test.zip
>
>
> If an image is put inside an <a href=""> and </a> tags, it's not working as a part of the link - it's not clickable and mouse cursor doesn't change shape over it.
> To reproduce, unpack the attached test.zip file and run 'java Test'. Then try moving the mouse over the image and clicking. Compare to moving mouse over and clicking the text besides the image.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-4575) [classlib][swing][html] Images in
links are not working properly
Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523520 ]
Dmitry Irlyanov commented on HARMONY-4575:
------------------------------------------
Alexey,
I'm fully agree with you. I think it should be changed and AFAIK translateHTMLToCSS works correctly.
> [classlib][swing][html] Images in links are not working properly
> ----------------------------------------------------------------
>
> Key: HARMONY-4575
> URL: https://issues.apache.org/jira/browse/HARMONY-4575
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Vasily Zakharov
> Assignee: Alexey Petrenko
> Attachments: H4575-ImageView-HTMLDocument.patch, test.zip
>
>
> If an image is put inside an <a href=""> and </a> tags, it's not working as a part of the link - it's not clickable and mouse cursor doesn't change shape over it.
> To reproduce, unpack the attached test.zip file and run 'java Test'. Then try moving the mouse over the image and clicking. Compare to moving mouse over and clicking the text besides the image.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4575) [classlib][swing][html] Images in
links are not working properly
Posted by "Vasily Zakharov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vasily Zakharov updated HARMONY-4575:
-------------------------------------
Attachment: test.zip
> [classlib][swing][html] Images in links are not working properly
> ----------------------------------------------------------------
>
> Key: HARMONY-4575
> URL: https://issues.apache.org/jira/browse/HARMONY-4575
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Vasily Zakharov
> Attachments: test.zip
>
>
> If an image is put inside an <a href=""> and </a> tags, it's not working as a part of the link - it's not clickable and mouse cursor doesn't change shape over it.
> To reproduce, unpack the attached test.zip file and run 'java Test'. Then try moving the mouse over the image and clicking. Compare to moving mouse over and clicking the text besides the image.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4575) [classlib][swing][html] Images in
links are not working properly
Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Petrenko updated HARMONY-4575:
-------------------------------------
Patch Info: [Patch Available]
> [classlib][swing][html] Images in links are not working properly
> ----------------------------------------------------------------
>
> Key: HARMONY-4575
> URL: https://issues.apache.org/jira/browse/HARMONY-4575
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Vasily Zakharov
> Attachments: H4575-ImageView-HTMLDocument.patch, H4575-ImageView-HTMLDocument.patch, test.zip
>
>
> If an image is put inside an <a href=""> and </a> tags, it's not working as a part of the link - it's not clickable and mouse cursor doesn't change shape over it.
> To reproduce, unpack the attached test.zip file and run 'java Test'. Then try moving the mouse over the image and clicking. Compare to moving mouse over and clicking the text besides the image.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-4575) [classlib][swing][html] Images in
links are not working properly
Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Petrenko reassigned HARMONY-4575:
----------------------------------------
Assignee: Alexey Petrenko
> [classlib][swing][html] Images in links are not working properly
> ----------------------------------------------------------------
>
> Key: HARMONY-4575
> URL: https://issues.apache.org/jira/browse/HARMONY-4575
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Vasily Zakharov
> Assignee: Alexey Petrenko
> Attachments: H4575-ImageView-HTMLDocument.patch, H4575-ImageView-HTMLDocument.patch, test.zip
>
>
> If an image is put inside an <a href=""> and </a> tags, it's not working as a part of the link - it's not clickable and mouse cursor doesn't change shape over it.
> To reproduce, unpack the attached test.zip file and run 'java Test'. Then try moving the mouse over the image and clicking. Compare to moving mouse over and clicking the text besides the image.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4575) [classlib][swing][html] Images in
links are not working properly
Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Irlyanov updated HARMONY-4575:
-------------------------------------
Attachment: H4575-ImageView-HTMLDocument.patch
> [classlib][swing][html] Images in links are not working properly
> ----------------------------------------------------------------
>
> Key: HARMONY-4575
> URL: https://issues.apache.org/jira/browse/HARMONY-4575
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Vasily Zakharov
> Attachments: H4575-ImageView-HTMLDocument.patch, H4575-ImageView-HTMLDocument.patch, test.zip
>
>
> If an image is put inside an <a href=""> and </a> tags, it's not working as a part of the link - it's not clickable and mouse cursor doesn't change shape over it.
> To reproduce, unpack the attached test.zip file and run 'java Test'. Then try moving the mouse over the image and clicking. Compare to moving mouse over and clicking the text besides the image.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-4575) [classlib][swing][html] Images in
links are not working properly
Posted by "Vasily Zakharov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523530 ]
Vasily Zakharov commented on HARMONY-4575:
------------------------------------------
Alexey, Dmitry - shouldn't we reopen this issue, or may create a new one, to track those additional improvements?
> [classlib][swing][html] Images in links are not working properly
> ----------------------------------------------------------------
>
> Key: HARMONY-4575
> URL: https://issues.apache.org/jira/browse/HARMONY-4575
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Vasily Zakharov
> Assignee: Alexey Petrenko
> Attachments: H4575-ImageView-HTMLDocument.patch, test.zip
>
>
> If an image is put inside an <a href=""> and </a> tags, it's not working as a part of the link - it's not clickable and mouse cursor doesn't change shape over it.
> To reproduce, unpack the attached test.zip file and run 'java Test'. Then try moving the mouse over the image and clicking. Compare to moving mouse over and clicking the text besides the image.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4575) [classlib][swing][html] Images in
links are not working properly
Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Irlyanov updated HARMONY-4575:
-------------------------------------
Attachment: H4575-ImageView-HTMLDocument.patch
> [classlib][swing][html] Images in links are not working properly
> ----------------------------------------------------------------
>
> Key: HARMONY-4575
> URL: https://issues.apache.org/jira/browse/HARMONY-4575
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Vasily Zakharov
> Assignee: Alexey Petrenko
> Attachments: H4575-ImageView-HTMLDocument.patch, test.zip
>
>
> If an image is put inside an <a href=""> and </a> tags, it's not working as a part of the link - it's not clickable and mouse cursor doesn't change shape over it.
> To reproduce, unpack the attached test.zip file and run 'java Test'. Then try moving the mouse over the image and clicking. Compare to moving mouse over and clicking the text besides the image.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-4575) [classlib][swing][html] Images in
links are not working properly
Posted by "Vasily Zakharov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vasily Zakharov closed HARMONY-4575.
------------------------------------
Dmitry, Alexey, thank you very much, the patch works as expected.
> [classlib][swing][html] Images in links are not working properly
> ----------------------------------------------------------------
>
> Key: HARMONY-4575
> URL: https://issues.apache.org/jira/browse/HARMONY-4575
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Vasily Zakharov
> Assignee: Alexey Petrenko
> Attachments: H4575-ImageView-HTMLDocument.patch, test.zip
>
>
> If an image is put inside an <a href=""> and </a> tags, it's not working as a part of the link - it's not clickable and mouse cursor doesn't change shape over it.
> To reproduce, unpack the attached test.zip file and run 'java Test'. Then try moving the mouse over the image and clicking. Compare to moving mouse over and clicking the text besides the image.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4575) [classlib][swing][html] Images in
links are not working properly
Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Irlyanov updated HARMONY-4575:
-------------------------------------
Attachment: H4575-ImageView-HTMLDocument.patch
The patch refreshed
> [classlib][swing][html] Images in links are not working properly
> ----------------------------------------------------------------
>
> Key: HARMONY-4575
> URL: https://issues.apache.org/jira/browse/HARMONY-4575
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Vasily Zakharov
> Assignee: Alexey Petrenko
> Attachments: H4575-ImageView-HTMLDocument.patch, H4575-ImageView-HTMLDocument.patch, H4575-ImageView-HTMLDocument.patch, test.zip
>
>
> If an image is put inside an <a href=""> and </a> tags, it's not working as a part of the link - it's not clickable and mouse cursor doesn't change shape over it.
> To reproduce, unpack the attached test.zip file and run 'java Test'. Then try moving the mouse over the image and clicking. Compare to moving mouse over and clicking the text besides the image.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.