You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "afzal442 (via GitHub)" <gi...@apache.org> on 2023/05/25 08:01:27 UTC
[GitHub] [apisix-ingress-controller] afzal442 commented on a diff in pull request #1819: chore: updates latest go mod lib and modifies the ginkgo install instruction
afzal442 commented on code in PR #1819:
URL: https://github.com/apache/apisix-ingress-controller/pull/1819#discussion_r1205143051
##########
Makefile:
##########
@@ -151,6 +151,7 @@ e2e-test-local: kind-up e2e-test
ginkgo-check:
ifeq ("$(wildcard $(GINKGO))", "")
@echo "ERROR: Need to install ginkgo first, run: go get -u github.com/onsi/ginkgo/v2/ginkgo@v2.9.2 or go install -mod=mod github.com/onsi/ginkgo/v2/ginkgo@v2.9.2"
+ @echo "Then, you need to add $GOPATH/bin to your PATH, run: export PATH="$(go env GOPATH)/bin:$PATH""
Review Comment:
@tao12345666333 as a gentle reminder, in case you forgot. LMK if it makes sense now. TY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org