You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:32:10 UTC

[GitHub] [flink] xiaolong-sn opened a new pull request #13002: Feature/flink 18661 efo de registration

xiaolong-sn opened a new pull request #13002:
URL: https://github.com/apache/flink/pull/13002


   
   ## What is the purpose of the change
   
   *This is the milestone of [FLIP-128](https://cwiki.apache.org/confluence/display/FLINK/FLIP-128%3A+Enhanced+Fan+Out+for+AWS+Kinesis+Consumers) to add EFO support to the FlinkKinesisConsumer. 
   The de-/regisiterStream operations has been introduce.* 
   [JIRA issue](https://issues.apache.org/jira/browse/FLINK-18661)
   
   ## Note
   This PR is blocked by:
   - Test coverage improvements:
     - [JIRA issue](https://issues.apache.org/jira/browse/FLINK-18483)
     - [Pull request](https://github.com/apache/flink/pull/12850)
   - Introducing RecordPublisher.
      - [JIRA issue](https://issues.apache.org/jira/browse/FLINK-18512)
      - [Pull request](https://github.com/apache/flink/pull/12881)
    - Add AWS SDK v2.x dependency and KinesisProxyV2
      - [JIRA issue](https://issues.apache.org/jira/browse/FLINK-18513)
      - [Pull request](https://github.com/apache/flink/pull/12944)
   -  Configuration deserialisation and validation
      - [JIRA issue](https://issues.apache.org/jira/browse/FLINK-18536)
      - [Pull request](https://github.com/apache/flink/pull/12920)
      
    
   
   ## Brief change log
   
     - `ConsumerConstants`
       - *Add the describe stream and descrbie stream consumer operation parameters.* 
     - `KinesisConfigUtil`
         - *Add the validation of the above parameter*
      - `FanOutStreamInfo`
          - *Add a new data class for storing enhanced fan-out consumer info.*
      - `FlinkDataFetcher`
          - *Add a KinesisProxyV2Interface in order to register stream consumers when the efo registration mode is set to eager.*
      - `ShardConsumer`
        - *Add a KinesisProxyV2Interface in order to de-/register stream consumers when the efo registration mode is set to lazy.*
      - `KinesisProxyV2Interface` & `KinesisProxyV2`
        - *Add the de-/register stream consumer operations here.*
      - `AwsV2Util`
        - *Add several methods to classify exceptions.* 
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
     - *`KinesisProxyV2Test`*
     - *`AwsV2UtilTest`*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no 
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13002: Feature/flink 18661 efo de registration

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13002:
URL: https://github.com/apache/flink/pull/13002#issuecomment-664747240


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "112bc7c63446b03f56dee492a773bbf6a8f86d33",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4943",
       "triggerID" : "112bc7c63446b03f56dee492a773bbf6a8f86d33",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 112bc7c63446b03f56dee492a773bbf6a8f86d33 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4943) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13002: Feature/flink 18661 efo de registration

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13002:
URL: https://github.com/apache/flink/pull/13002#issuecomment-664743155






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] xiaolong-sn closed pull request #13002: Feature/flink 18661 efo de registration

Posted by GitBox <gi...@apache.org>.
xiaolong-sn closed pull request #13002:
URL: https://github.com/apache/flink/pull/13002


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org