You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "cyril23 (via GitHub)" <gi...@apache.org> on 2026/03/25 14:19:42 UTC
[PR] fix(ios): remove redundant #import for Xcode 26 compatibility [cordova-plugin-network-information]
cyril23 opened a new pull request, #166:
URL: https://github.com/apache/cordova-plugin-network-information/pull/166
## Summary
Fixes #165
Xcode 26 enforces stricter module boundaries and rejects the private header `netinet6/in6.h` when imported directly from `CDVReachability.m`, causing iOS builds to fail:
```
CDVReachability.m:49:9: error: Use of private header from outside its module: 'netinet6/in6.h'
```
## Change
Remove the redundant `#import <netinet6/in6.h>` from `src/ios/CDVReachability.m`.
This import is unnecessary because:
- `netinet/in.h` (already imported on the previous line) transitively includes `netinet6/in6.h`
- No IPv6-specific types (`sockaddr_in6`, `in6_addr`, `IN6_*`) from `netinet6/in6.h` are used directly in `CDVReachability.m`
## Testing
Verified with production Cordova builds (cordova-ios 7.1.0, Cordova CLI 13.0.0) on Xcode 26.4 (17E192). Both debug IPA and APK build successfully after the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] fix(ios): remove redundant #import for Xcode 26.4 compatibility [cordova-plugin-network-information]
Posted by "GitToTheHub (via GitHub)" <gi...@apache.org>.
GitToTheHub commented on PR #166:
URL: https://github.com/apache/cordova-plugin-network-information/pull/166#issuecomment-4162327582
I will try to initiate a release in few days, but depends on the other members of Cordova also and their free time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] fix(ios): remove redundant #import for Xcode 26.4 compatibility [cordova-plugin-network-information]
Posted by "petercutting (via GitHub)" <gi...@apache.org>.
petercutting commented on PR #166:
URL: https://github.com/apache/cordova-plugin-network-information/pull/166#issuecomment-4241850593
apparently this fix can be tested by getting the plugin fom git. Just need to find the right npm command
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] fix(ios): remove redundant #import for Xcode 26.4 compatibility [cordova-plugin-network-information]
Posted by "tobias-klein (via GitHub)" <gi...@apache.org>.
tobias-klein commented on PR #166:
URL: https://github.com/apache/cordova-plugin-network-information/pull/166#issuecomment-4182736927
@cyril23 Thank you for contributing this patch! :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] fix(ios): remove redundant #import for Xcode 26 compatibility [cordova-plugin-network-information]
Posted by "breautek (via GitHub)" <gi...@apache.org>.
breautek commented on PR #166:
URL: https://github.com/apache/cordova-plugin-network-information/pull/166#issuecomment-4128158986
I see that Claude was used to produce the commit / PR. This is fine at the time of writing under [Apache's Generative AI](https://www.apache.org/legal/generative-tooling.html) policy, but Apache would like `Generated-by: ` tag to be included in the commit message.
I think including `Generated-by: Claude` would be satisfactory.
> When providing contributions authored using generative AI tooling, a recommended practice is for contributors to indicate the tooling used to create the contribution. This should be included as a token in the source control commit message, for example including the phrase “Generated-by: ”. This allows for future release tooling to be considered that pulls this content into a machine parsable Tooling-Provenance file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] fix(ios): remove redundant #import for Xcode 26 compatibility [cordova-plugin-network-information]
Posted by "GitToTheHub (via GitHub)" <gi...@apache.org>.
GitToTheHub merged PR #166:
URL: https://github.com/apache/cordova-plugin-network-information/pull/166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] fix(ios): remove redundant #import for Xcode 26.4 compatibility [cordova-plugin-network-information]
Posted by "jacobg (via GitHub)" <gi...@apache.org>.
jacobg commented on PR #166:
URL: https://github.com/apache/cordova-plugin-network-information/pull/166#issuecomment-4151172881
When will this be published?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] fix(ios): remove redundant #import for Xcode 26 compatibility [cordova-plugin-network-information]
Posted by "cyril23 (via GitHub)" <gi...@apache.org>.
cyril23 commented on PR #166:
URL: https://github.com/apache/cordova-plugin-network-information/pull/166#issuecomment-4132593685
@breautek Thanks for the feedback! I've amended the commit message to include the `Generated-by: Claude` tag per Apache's Generative AI policy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] fix(ios): remove redundant #import for Xcode 26.4 compatibility [cordova-plugin-network-information]
Posted by "GitToTheHub (via GitHub)" <gi...@apache.org>.
GitToTheHub commented on PR #166:
URL: https://github.com/apache/cordova-plugin-network-information/pull/166#issuecomment-4136352782
This is related to XCode 26.4 only. On XCode 26.3 and older the build error does not occur.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org