You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2018/06/30 10:15:36 UTC
[GitHub] codecov-io edited a comment on issue #1957: [Dubbo-1876]
Enhancements for the new async way of Dubbo
codecov-io edited a comment on issue #1957: [Dubbo-1876] Enhancements for the new async way of Dubbo
URL: https://github.com/apache/incubator-dubbo/pull/1957#issuecomment-398378445
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1957?src=pr&el=h1) Report
> Merging [#1957](https://codecov.io/gh/apache/incubator-dubbo/pull/1957?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/d21d9942b37ad5baccf698b19a17b372c0c9557c?src=pr&el=desc) will **increase** coverage by `1%`.
> The diff coverage is `26.06%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/1957?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1957 +/- ##
==========================================
+ Coverage 50.04% 51.05% +1%
- Complexity 4706 4802 +96
==========================================
Files 562 564 +2
Lines 25213 25306 +93
Branches 4449 4453 +4
==========================================
+ Hits 12618 12920 +302
+ Misses 10690 10442 -248
- Partials 1905 1944 +39
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1957?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ache/dubbo/rpc/protocol/thrift/ThriftProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1957/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10aHJpZnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90aHJpZnQvVGhyaWZ0UHJvdG9jb2wuamF2YQ==) | `22.97% <ø> (ø)` | `6 <0> (ø)` | :arrow_down: |
| [.../src/main/java/org/apache/dubbo/rpc/RpcResult.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1957/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNSZXN1bHQuamF2YQ==) | `50% <ø> (+11.53%)` | `7 <0> (ø)` | :arrow_down: |
| [...c/main/java/org/apache/dubbo/common/Constants.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1957/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vQ29uc3RhbnRzLmphdmE=) | `88.88% <ø> (ø)` | `1 <0> (ø)` | :arrow_down: |
| [...oting/exchange/support/ExchangeHandlerAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1957/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L0V4Y2hhbmdlSGFuZGxlckFkYXB0ZXIuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...main/java/org/apache/dubbo/rpc/AsyncRpcResult.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1957/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9Bc3luY1JwY1Jlc3VsdC5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/dubbo/rpc/proxy/InvokerInvocationHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1957/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm94eS9JbnZva2VySW52b2NhdGlvbkhhbmRsZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...exchange/support/header/HeaderExchangeHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1957/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFkZXJFeGNoYW5nZUhhbmRsZXIuamF2YQ==) | `30.15% <0%> (ø)` | `10 <0> (ø)` | :arrow_down: |
| [...ava/org/apache/dubbo/rpc/SimpleAsyncRpcResult.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1957/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9TaW1wbGVBc3luY1JwY1Jlc3VsdC5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...le/src/main/java/com/alibaba/dubbo/rpc/Result.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1957/diff?src=pr&el=tree#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9SZXN1bHQuamF2YQ==) | `22.22% <0%> (-11.12%)` | `0 <0> (ø)` | |
| [...src/main/java/org/apache/dubbo/rpc/RpcContext.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1957/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNDb250ZXh0LmphdmE=) | `31.25% <0%> (+0.87%)` | `30 <0> (+1)` | :arrow_up: |
| ... and [40 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1957/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1957?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1957?src=pr&el=footer). Last update [d21d994...4977d6c](https://codecov.io/gh/apache/incubator-dubbo/pull/1957?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org