[jira] [Comment Edited] (GEODE-165) Add build support for generating antlr classes from grammar

["Bruce Schuchardt (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15781062#comment-15781062 ] 

Bruce Schuchardt edited comment on GEODE-165 at 12/27/16 7:24 PM:
------------------------------------------------------------------

IntelliJ Idea 2016.3.1 builds are broken by this change.  You must close your project and re-import the gradle build to fix the problem.  A workaround is to generate the absent source files with gradle.


was (Author: bschuchardt):
IntelliJ Idea 2016.3.1 builds are broken by this change.  A workaround is to do a command-line build to have the generated-source files be created.

> Add build support for generating antlr classes from grammar
> -----------------------------------------------------------
>
>                 Key: GEODE-165
>                 URL: https://issues.apache.org/jira/browse/GEODE-165
>             Project: Geode
>          Issue Type: Bug
>          Components: build
>            Reporter: Dan Smith
>            Assignee: Avinash Dongre
>
> The OQL engine currently uses antlr to generate some parsing classes from 
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/parse/oql.g
> These are the generated classes. They are currently checked into the source.
> OQLLexer.java
> OQLLexerTokenTypes.java
> OQLLexerTokenTypes.txt
> OQLParser.java
> They can be generated manually by running antlr.Tool on the provided grammar.
> cd gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/parse/
> java -cp antlr.jar antlr.Tool oql.g
> We should add support to the gradle build to generate these classes.
> In my opinion we should also remove the checked in classes. With gradle we can configure things so that the gradle eclipse target will generate these classes and make them available to the IDE as well. Look at gemfire-core/build.gradle for how we do this with the version properties file:
> sourceSets {
>   main {
>     output.dir(generatedResources, builtBy: 'createVersionPropertiesFile')
>   }
> }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)