You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/11/11 10:22:34 UTC
[GitHub] [spark] zero323 opened a new pull request #34555: [SPARK-37288][PYTHON] Backport since annotation update
zero323 opened a new pull request #34555:
URL: https://github.com/apache/spark/pull/34555
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR changes since annotation to support `float` arguments:
```python
def since(version: Union[str, float]) -> Callable[[T], T]: ...
```
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
`since` is used with both `str` and `float` both in Spark and related libraries and this change has been already done for Spark >= 3.3 (SPARK-36906),
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
```python
@since(3.2)
def f():
...
```
is going to type check.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Existing tests and manual testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #34555: [SPARK-37288][PYTHON][3.2] Backport since annotation update
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #34555:
URL: https://github.com/apache/spark/pull/34555#issuecomment-966740024
> This type hint stuff are actually something boundary between Improvement and Bug. For example, with incorrect type hints, IDE would warn that the types and arguments are mismatched. With correct type hints, it won't warn anymore.
That's also my reasoning behind marking it as an Improvement not a Bug. In many ways, we used to treat hints fixes more like documentation changes, than code changes until now, though current migration is most likely to change that.
> While I think it's fine to don't backport since is only for internal purpose,
It is not indicated as internal and in fact there are known public usages outside Spark (and likely, private as well).
In general, we used to routinely backport simple annotation changes until now, because of non-intrusive character and borderline bug characteristic. If this was detected separately from SPARK-36845, I'd expect it would be handled the same way.
That being said, I don't have strong opinion about this ‒ if consensus here is to mark it as wontfix, I am OK with that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34555: [SPARK-37288][PYTHON][3.2] Backport since annotation update
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34555:
URL: https://github.com/apache/spark/pull/34555#issuecomment-967790800
I switched the JIRA to a bug, and described which bug this PR fixes. It wouldn't introduce any user-facing behaviour. cc @dongjoon-hyun.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-databricks commented on pull request #34555: [SPARK-37288][PYTHON][3.2] Backport since annotation update
Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on pull request #34555:
URL: https://github.com/apache/spark/pull/34555#issuecomment-967708311
Thanks @zero323 for the effort! I am neutral as per the discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on pull request #34555: [SPARK-37288][PYTHON][3.2] Backport since annotation update
Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on pull request #34555:
URL: https://github.com/apache/spark/pull/34555#issuecomment-967790800
I switched the JIRA to a bug, and described which bug this PR fixes. It wouldn't introduce any user-facing behaviour change. cc @dongjoon-hyun.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34555: [SPARK-37288][PYTHON] Backport since annotation update
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34555:
URL: https://github.com/apache/spark/pull/34555#issuecomment-966288005
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49575/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #34555: [SPARK-37288][PYTHON][3.2] Backport since annotation update
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #34555:
URL: https://github.com/apache/spark/pull/34555#issuecomment-968138310
Thanks @dongjoon-hyun, @HyukjinKwon, @xinrong-databricks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #34555: [SPARK-37288][PYTHON] Backport since annotation update
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #34555:
URL: https://github.com/apache/spark/pull/34555#issuecomment-966183128
CC @xinrong-databricks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34555: [SPARK-37288][PYTHON][3.2] Backport since annotation update
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34555:
URL: https://github.com/apache/spark/pull/34555#issuecomment-966728384
While I think it's fine to don't backport `since` is only for internal purpose, the risk is almost zero so I am not particularly against the backport.
This type hint stuff are actually something boundary between Improvement and Bug. For example, with incorrect type hints, IDE would warn that the types and arguments are mismatched. With correct type hints, it won't warn anymore.
Another point is that mypy checker in the downstream project won't work correctly although they typed correctly. This would have to be considered as a bug..
@zero323 maybe we should better clarify what _bug_ this PR fixes since only bug fixes are backported to other branches in standard practice, and what @dongjoon-hyun said here makes sense in the sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34555: [SPARK-37288][PYTHON][3.2] Backport since annotation update
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34555:
URL: https://github.com/apache/spark/pull/34555#issuecomment-968080677
Merged to branch-3.2 and branch-3.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #34555: [SPARK-37288][PYTHON][3.2] Backport since annotation update
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #34555:
URL: https://github.com/apache/spark/pull/34555
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34555: [SPARK-37288][PYTHON] Backport since annotation update
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34555:
URL: https://github.com/apache/spark/pull/34555#issuecomment-966288005
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49575/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34555: [SPARK-37288][PYTHON] Backport since annotation update
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34555:
URL: https://github.com/apache/spark/pull/34555#issuecomment-966185667
**[Test build #145106 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145106/testReport)** for PR 34555 at commit [`379bbd4`](https://github.com/apache/spark/commit/379bbd43bed02b888282ce3fbdd5cb79e8db0015).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34555: [SPARK-37288][PYTHON] Backport since annotation update
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34555:
URL: https://github.com/apache/spark/pull/34555#issuecomment-966185667
**[Test build #145106 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145106/testReport)** for PR 34555 at commit [`379bbd4`](https://github.com/apache/spark/commit/379bbd43bed02b888282ce3fbdd5cb79e8db0015).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34555: [SPARK-37288][PYTHON] Backport since annotation update
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34555:
URL: https://github.com/apache/spark/pull/34555#issuecomment-966269689
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49575/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34555: [SPARK-37288][PYTHON] Backport since annotation update
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34555:
URL: https://github.com/apache/spark/pull/34555#issuecomment-966246934
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49575/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34555: [SPARK-37288][PYTHON] Backport since annotation update
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34555:
URL: https://github.com/apache/spark/pull/34555#issuecomment-966212116
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145106/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on pull request #34555: [SPARK-37288][PYTHON][3.2] Backport since annotation update
Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on pull request #34555:
URL: https://github.com/apache/spark/pull/34555#issuecomment-966728384
While I think it's fine to don't backport `since` is only for internal purpose, the risk is almost zero so I am not particularly against the backport.
This type hint stuff are actually something boundary between Improvement and Bug. For example, with incorrect type hints, IDE would warn that the types and arguments are mismatched. With correct type hints, it won't warn anymore.
Another point is that mypy checker in the downstream project won't work correctly although they typed correctly. This would have to be considered as a bug..
@zero323 maybe we should better clarify what _bug_ this PR fixes since only bug fixes are backported to other branches in standard practice, and what @dongjoon-hyun said here makes sense in that way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34555: [SPARK-37288][PYTHON] Backport since annotation update
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34555:
URL: https://github.com/apache/spark/pull/34555#issuecomment-966204607
**[Test build #145106 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145106/testReport)** for PR 34555 at commit [`379bbd4`](https://github.com/apache/spark/commit/379bbd43bed02b888282ce3fbdd5cb79e8db0015).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34555: [SPARK-37288][PYTHON] Backport since annotation update
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34555:
URL: https://github.com/apache/spark/pull/34555#issuecomment-966212116
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145106/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34555: [SPARK-37288][PYTHON][3.2] Backport since annotation update
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34555:
URL: https://github.com/apache/spark/pull/34555#issuecomment-967817527
Thanks @dongjoon-hyun. lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org