You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@arrow.apache.org by "Brian Hulette (JIRA)" <ji...@apache.org> on 2018/12/04 03:22:00 UTC

[jira] [Updated] (ARROW-3337) [JS] IPC writer doesn't serialize the dictionary of nested Vectors

     [ https://issues.apache.org/jira/browse/ARROW-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Hulette updated ARROW-3337:
---------------------------------
    Fix Version/s:     (was: JS-0.4.0)
                   JS-0.5.0

> [JS] IPC writer doesn't serialize the dictionary of nested Vectors
> ------------------------------------------------------------------
>
>                 Key: ARROW-3337
>                 URL: https://issues.apache.org/jira/browse/ARROW-3337
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: JavaScript
>    Affects Versions: JS-0.3.1
>            Reporter: Paul Taylor
>            Assignee: Paul Taylor
>            Priority: Major
>             Fix For: JS-0.5.0
>
>
> The JS writer only serializes dictionaries for [top-level children|https://github.com/apache/arrow/blob/ee9b1ba426e2f1f117cde8d8f4ba6fbe3be5674c/js/src/ipc/writer/binary.ts#L40] of a Table. This is wrong, and an oversight on my part. The fix here is to put the actual Dictionary vectors in the `schema.dictionaries` map instead of the dictionary fields, like I understand the C++ does.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)