You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/07/17 17:27:27 UTC

[GitHub] [hbase] virajjasani commented on a change in pull request #2079: HBASE-24747 Log an ERROR if HBaseSaslRpcServer initialisation fails w…

virajjasani commented on a change in pull request #2079:
URL: https://github.com/apache/hbase/pull/2079#discussion_r456575593



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ServerRpcConnection.java
##########
@@ -348,8 +348,14 @@ public void saslReadAndProcess(ByteBuff saslToken) throws IOException,
       byte[] replyToken;
       try {
         if (saslServer == null) {
-          saslServer =
+          try {
+            saslServer =
               new HBaseSaslRpcServer(provider, rpcServer.saslProps, rpcServer.secretManager);
+          } catch (Exception e){

Review comment:
       nit: this can be IOException? Exception is also fine though since the purpose is to log any uncaught exceptions.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org