You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@gmail.com> on 2016/11/01 00:48:58 UTC
Re: Review Request 53073: Lineage REST API v2 implementation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53073/
-----------------------------------------------------------
(Updated Oct. 31, 2016, 5:48 p.m.)
Review request for atlas, Apoorv Naik, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.
Changes
-------
Addressed review changes and now using the new AtlasEntityHeader for concise entity information
Bugs: ATLAS-1234
https://issues.apache.org/jira/browse/ATLAS-1234
Repository: atlas
Description
-------
Initial model for updated lineage rest apis for input, output and full lineage for dataset.
Diffs (updated)
-----
common/src/main/java/org/apache/atlas/repository/Constants.java 4a68317
intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java PRE-CREATION
intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageService.java PRE-CREATION
repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 129591a
repository/src/main/java/org/apache/atlas/discovery/InstanceLineageService.java PRE-CREATION
repository/src/main/scala/org/apache/atlas/query/ClosureQuery.scala 569d3f9
webapp/src/main/java/org/apache/atlas/web/rest/LineageREST.java PRE-CREATION
Diff: https://reviews.apache.org/r/53073/diff/
Testing (updated)
-------
Currently working on UT's and to use Atlas error codes.
Thanks,
Sarath Subramanian
Re: Review Request 53073: Lineage REST API v2 implementation
Posted by Sarath Subramanian <sa...@gmail.com>.
> On Nov. 3, 2016, 1:38 p.m., Suma Shivaprasad wrote:
> > repository/src/main/scala/org/apache/atlas/query/ClosureQuery.scala, line 148
> > <https://reviews.apache.org/r/53073/diff/6/?file=1552851#file1552851line148>
> >
> > is depth mandatory or should we also provide infinite depth to keep it backward compatible with older API.
when depth is passed as -1, it gives infinite lineage
- Sarath
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53073/#review154802
-----------------------------------------------------------
On Nov. 10, 2016, 3:24 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53073/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2016, 3:24 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1234
> https://issues.apache.org/jira/browse/ATLAS-1234
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Initial model and implementation for updated lineage rest apis for input, output and full lineage for dataset entity.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/repository/Constants.java 4a68317
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java fe38fba
> intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageService.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java aabf269
> repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/lineage/EntityLineageServiceTest.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/rest/LineageREST.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53073/diff/
>
>
> Testing
> -------
>
> unit test and integration test updated.
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 53073: Lineage REST API v2 implementation
Posted by Sarath Subramanian <sa...@gmail.com>.
> On Nov. 3, 2016, 1:38 p.m., Suma Shivaprasad wrote:
> >
depth is not mandatory param, the default depth is 3 if not specified.
- Sarath
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53073/#review154802
-----------------------------------------------------------
On Nov. 3, 2016, 2:47 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53073/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2016, 2:47 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1234
> https://issues.apache.org/jira/browse/ATLAS-1234
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Initial model for updated lineage rest apis for input, output and full lineage for dataset.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/repository/Constants.java 4a68317
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 709fcbc
> intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageService.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 0325c80
> repository/src/main/java/org/apache/atlas/discovery/InstanceLineageService.java PRE-CREATION
> repository/src/main/scala/org/apache/atlas/query/ClosureQuery.scala 569d3f9
> repository/src/test/java/org/apache/atlas/lineage/InstanceLineageServiceTest.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/rest/LineageREST.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/resources/InstanceLineageJerseyResourceIT.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53073/diff/
>
>
> Testing
> -------
>
> Currently working on UT's
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 53073: Lineage REST API v2 implementation
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53073/#review154802
-----------------------------------------------------------
repository/src/main/scala/org/apache/atlas/query/ClosureQuery.scala (line 148)
<https://reviews.apache.org/r/53073/#comment224501>
is depth mandatory or should we also provide infinite depth to keep it backward compatible with older API.
- Suma Shivaprasad
On Nov. 3, 2016, 8:07 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53073/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2016, 8:07 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1234
> https://issues.apache.org/jira/browse/ATLAS-1234
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Initial model for updated lineage rest apis for input, output and full lineage for dataset.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/repository/Constants.java 4a68317
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 709fcbc
> intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageService.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 0325c80
> repository/src/main/java/org/apache/atlas/discovery/InstanceLineageService.java PRE-CREATION
> repository/src/main/scala/org/apache/atlas/query/ClosureQuery.scala 569d3f9
> repository/src/test/java/org/apache/atlas/lineage/InstanceLineageServiceTest.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/rest/LineageREST.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53073/diff/
>
>
> Testing
> -------
>
> Currently working on UT's
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 53073: Lineage REST API v2 implementation
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53073/#review154841
-----------------------------------------------------------
intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java (line 42)
<https://reviews.apache.org/r/53073/#comment224571>
- consider renaming and reordering attributes as given below:
- baseEntityGuid (currently 'baseEntityId')
- lineageDirection
- lineageMaxDepth
- guidEntityMap (currently 'entities')
- relations
intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java (line 67)
<https://reviews.apache.org/r/53073/#comment224572>
Use camel case, like - getBaseEntityId()
intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageService.java (line 42)
<https://reviews.apache.org/r/53073/#comment224600>
Consider providing a single method, with the following signature. 'options' parameter can be used to extend the API to specify any customer behaviour - when needed.
AtlasLineageInfo getLineageInfo(String entityGuid, LineageDirection direction, int maxDepth, Map<String, String> options);
repository/src/main/java/org/apache/atlas/discovery/InstanceLineageService.java (line 61)
<https://reviews.apache.org/r/53073/#comment224643>
Consider renaming this class to "EntityLineageService" - to be consistent with use of "Entity" (instead of "Instance").
- Madhan Neethiraj
On Nov. 3, 2016, 9:54 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53073/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2016, 9:54 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1234
> https://issues.apache.org/jira/browse/ATLAS-1234
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Initial model for updated lineage rest apis for input, output and full lineage for dataset.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/repository/Constants.java 4a68317
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 709fcbc
> intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageService.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 0325c80
> repository/src/main/java/org/apache/atlas/discovery/InstanceLineageService.java PRE-CREATION
> repository/src/main/scala/org/apache/atlas/query/ClosureQuery.scala 569d3f9
> repository/src/test/java/org/apache/atlas/lineage/InstanceLineageServiceTest.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/rest/LineageREST.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/resources/InstanceLineageJerseyResourceIT.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53073/diff/
>
>
> Testing
> -------
>
> unit test and integration test added.
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 53073: Lineage REST API v2 implementation
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53073/#review155749
-----------------------------------------------------------
Fix it, then Ship it!
intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java (line 117)
<https://reviews.apache.org/r/53073/#comment225828>
replace == with equals():
if (baseEntityId != null ? !baseEntityId.equals(that.baseEntityId) : that.baseEntityId != null) { return false; }
- Madhan Neethiraj
On Nov. 11, 2016, 9:59 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53073/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2016, 9:59 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1234
> https://issues.apache.org/jira/browse/ATLAS-1234
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Initial model and implementation for updated lineage rest apis for input, output and full lineage for dataset entity.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/repository/Constants.java 4a68317
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java fe38fba
> intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageService.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java aabf269
> repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/lineage/EntityLineageServiceTest.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/rest/LineageREST.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53073/diff/
>
>
> Testing
> -------
>
> unit test and integration test updated.
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 53073: Lineage REST API v2 implementation
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53073/
-----------------------------------------------------------
(Updated Nov. 11, 2016, 3:05 p.m.)
Review request for atlas, Apoorv Naik, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.
Changes
-------
changed equals() for baseEntityGuid
Bugs: ATLAS-1234
https://issues.apache.org/jira/browse/ATLAS-1234
Repository: atlas
Description
-------
Initial model and implementation for updated lineage rest apis for input, output and full lineage for dataset entity.
Diffs (updated)
-----
common/src/main/java/org/apache/atlas/repository/Constants.java 4a68317
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java fe38fba
intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java PRE-CREATION
intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageService.java PRE-CREATION
repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java aabf269
repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java PRE-CREATION
repository/src/test/java/org/apache/atlas/lineage/EntityLineageServiceTest.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/rest/LineageREST.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java PRE-CREATION
Diff: https://reviews.apache.org/r/53073/diff/
Testing
-------
unit test and integration test updated.
Thanks,
Sarath Subramanian
Re: Review Request 53073: Lineage REST API v2 implementation
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53073/
-----------------------------------------------------------
(Updated Nov. 11, 2016, 1:59 p.m.)
Review request for atlas, Apoorv Naik, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.
Changes
-------
addressed review comments and code refactoring.
Bugs: ATLAS-1234
https://issues.apache.org/jira/browse/ATLAS-1234
Repository: atlas
Description
-------
Initial model and implementation for updated lineage rest apis for input, output and full lineage for dataset entity.
Diffs (updated)
-----
common/src/main/java/org/apache/atlas/repository/Constants.java 4a68317
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java fe38fba
intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java PRE-CREATION
intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageService.java PRE-CREATION
repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java aabf269
repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java PRE-CREATION
repository/src/test/java/org/apache/atlas/lineage/EntityLineageServiceTest.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/rest/LineageREST.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java PRE-CREATION
Diff: https://reviews.apache.org/r/53073/diff/
Testing
-------
unit test and integration test updated.
Thanks,
Sarath Subramanian
Re: Review Request 53073: Lineage REST API v2 implementation
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53073/#review155670
-----------------------------------------------------------
intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java (line 204)
<https://reviews.apache.org/r/53073/#comment225739>
Consider moving enum def to the top of the source file.
Rename LineageInfoDirection ==> LineageDirection
repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java (line 116)
<https://reviews.apache.org/r/53073/#comment225723>
since 'depth' is already handled in getLineageQuery(), it is not necessary to check the depth again here. Please review and remove.
Please review getOutputLineageInfo() and getBothLineageInfo() as well.
repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java (line 124)
<https://reviews.apache.org/r/53073/#comment225744>
Consider replacing the for/while loops with the following:
for (List<AtlasEntityHeader> path : lineagePaths) {
AtlasEntityHeader prev = null;
for(AtlasEntityHeader entity : path) {
if (!entities.containsKey(entity.getGuid())) {
entities.put(entity.getGuid(), entity);
}
if (prev != null) {
relations.add(new AtlasLineageRelation(entity.getGuid(), prev.getGuid());
}
prev = entity;
}
}
repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java (line 194)
<https://reviews.apache.org/r/53073/#comment225748>
Given that AtlasLineageInfo.relations is a list, consider using List to combine both relations (instead of Set).
AtlasLineageInfo ret = inputLineage;
ret.getRelations().addAll(outputLineage.getRelations());
ret.getGuidEnitiesMap().putAll(outputLineage.getGuidEnitiesMap());
ret.setDirection(LineageInfoDirection.BOTH);
return ret;
repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java (line 213)
<https://reviews.apache.org/r/53073/#comment225750>
if only List is expected from the query, consider throwing an error when any other type is returned.
Please review line #220 as well for the same condition.
- Madhan Neethiraj
On Nov. 10, 2016, 11:24 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53073/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2016, 11:24 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1234
> https://issues.apache.org/jira/browse/ATLAS-1234
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Initial model and implementation for updated lineage rest apis for input, output and full lineage for dataset entity.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/repository/Constants.java 4a68317
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java fe38fba
> intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageService.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java aabf269
> repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/lineage/EntityLineageServiceTest.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/rest/LineageREST.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53073/diff/
>
>
> Testing
> -------
>
> unit test and integration test updated.
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 53073: Lineage REST API v2 implementation
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53073/
-----------------------------------------------------------
(Updated Nov. 10, 2016, 3:24 p.m.)
Review request for atlas, Apoorv Naik, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.
Changes
-------
* Addressed review comments
* Changed depth type to Integer and direction to Atlas LineageInfoDirection
* Added full lineage query to retrieve all lineage upon passing depth=-1 (to support legacy api)
* updated unit and integration tests
Bugs: ATLAS-1234
https://issues.apache.org/jira/browse/ATLAS-1234
Repository: atlas
Description
-------
Initial model and implementation for updated lineage rest apis for input, output and full lineage for dataset entity.
Diffs (updated)
-----
common/src/main/java/org/apache/atlas/repository/Constants.java 4a68317
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java fe38fba
intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java PRE-CREATION
intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageService.java PRE-CREATION
repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java aabf269
repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java PRE-CREATION
repository/src/test/java/org/apache/atlas/lineage/EntityLineageServiceTest.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/rest/LineageREST.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java PRE-CREATION
Diff: https://reviews.apache.org/r/53073/diff/
Testing
-------
unit test and integration test updated.
Thanks,
Sarath Subramanian
Re: Review Request 53073: Lineage REST API v2 implementation
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53073/#review155636
-----------------------------------------------------------
intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageService.java (line 32)
<https://reviews.apache.org/r/53073/#comment225648>
Consider replacing 'String direction' with 'LineageInfoDirection direction'.
intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageService.java (line 39)
<https://reviews.apache.org/r/53073/#comment225646>
Given that getLineageInfo() covers all directions - input/output/both, are methods getInputLineageInfo(), getOutputLineageInfo() and getBothLineageInfo() needed anymore?
repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java (line 84)
<https://reviews.apache.org/r/53073/#comment225647>
is 'direction' argument needed for getInputLineage()? It should implicitly be "input".
repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java (line 276)
<https://reviews.apache.org/r/53073/#comment225649>
- move member declaration to top of the file
- consider adding another query with no depth limit. This will be needed to suppor legacy APIs
webapp/src/main/java/org/apache/atlas/web/rest/LineageREST.java (line 67)
<https://reviews.apache.org/r/53073/#comment225652>
Instead of using "String" type for direction, consider using an enum.
webapp/src/main/java/org/apache/atlas/web/rest/LineageREST.java (line 68)
<https://reviews.apache.org/r/53073/#comment225651>
Why is depth of type 'String'? Consider using Integer type.
- Madhan Neethiraj
On Nov. 8, 2016, 9:46 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53073/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2016, 9:46 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1234
> https://issues.apache.org/jira/browse/ATLAS-1234
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Initial model and implementation for updated lineage rest apis for input, output and full lineage for dataset entity.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/repository/Constants.java 4a68317
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java fe38fba
> intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageService.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java aabf269
> repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/lineage/EntityLineageServiceTest.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/rest/LineageREST.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53073/diff/
>
>
> Testing
> -------
>
> unit test and integration test updated.
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 53073: Lineage REST API v2 implementation
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53073/
-----------------------------------------------------------
(Updated Nov. 8, 2016, 1:46 p.m.)
Review request for atlas, Apoorv Naik, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.
Changes
-------
updated unit and integration tests.
Bugs: ATLAS-1234
https://issues.apache.org/jira/browse/ATLAS-1234
Repository: atlas
Description
-------
Initial model and implementation for updated lineage rest apis for input, output and full lineage for dataset entity.
Diffs (updated)
-----
common/src/main/java/org/apache/atlas/repository/Constants.java 4a68317
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java fe38fba
intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java PRE-CREATION
intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageService.java PRE-CREATION
repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java aabf269
repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java PRE-CREATION
repository/src/test/java/org/apache/atlas/lineage/EntityLineageServiceTest.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/rest/LineageREST.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java PRE-CREATION
Diff: https://reviews.apache.org/r/53073/diff/
Testing (updated)
-------
unit test and integration test updated.
Thanks,
Sarath Subramanian
Re: Review Request 53073: Lineage REST API v2 implementation
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53073/
-----------------------------------------------------------
(Updated Nov. 8, 2016, 12:05 p.m.)
Review request for atlas, Apoorv Naik, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.
Changes
-------
1. Refactored lineage query to use Gremlin instead of closure query.
2. Addressed review comments.
3. Made API simpler to accept params - guid, direction and depth.
Bugs: ATLAS-1234
https://issues.apache.org/jira/browse/ATLAS-1234
Repository: atlas
Description (updated)
-------
Initial model and implementation for updated lineage rest apis for input, output and full lineage for dataset entity.
Diffs (updated)
-----
common/src/main/java/org/apache/atlas/repository/Constants.java 4a68317
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java fe38fba
intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java PRE-CREATION
intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageService.java PRE-CREATION
repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java aabf269
repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java PRE-CREATION
repository/src/test/java/org/apache/atlas/lineage/EntityLineageServiceTest.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/rest/LineageREST.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java PRE-CREATION
Diff: https://reviews.apache.org/r/53073/diff/
Testing
-------
unit test and integration test added.
Thanks,
Sarath Subramanian
Re: Review Request 53073: Lineage REST API v2 implementation
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53073/
-----------------------------------------------------------
(Updated Nov. 3, 2016, 2:54 p.m.)
Review request for atlas, Apoorv Naik, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.
Bugs: ATLAS-1234
https://issues.apache.org/jira/browse/ATLAS-1234
Repository: atlas
Description
-------
Initial model for updated lineage rest apis for input, output and full lineage for dataset.
Diffs
-----
common/src/main/java/org/apache/atlas/repository/Constants.java 4a68317
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 709fcbc
intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java PRE-CREATION
intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageService.java PRE-CREATION
repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 0325c80
repository/src/main/java/org/apache/atlas/discovery/InstanceLineageService.java PRE-CREATION
repository/src/main/scala/org/apache/atlas/query/ClosureQuery.scala 569d3f9
repository/src/test/java/org/apache/atlas/lineage/InstanceLineageServiceTest.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/rest/LineageREST.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/resources/InstanceLineageJerseyResourceIT.java PRE-CREATION
Diff: https://reviews.apache.org/r/53073/diff/
Testing (updated)
-------
unit test and integration test added.
Thanks,
Sarath Subramanian
Re: Review Request 53073: Lineage REST API v2 implementation
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53073/
-----------------------------------------------------------
(Updated Nov. 3, 2016, 2:47 p.m.)
Review request for atlas, Apoorv Naik, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.
Changes
-------
added integration tests
Bugs: ATLAS-1234
https://issues.apache.org/jira/browse/ATLAS-1234
Repository: atlas
Description
-------
Initial model for updated lineage rest apis for input, output and full lineage for dataset.
Diffs (updated)
-----
common/src/main/java/org/apache/atlas/repository/Constants.java 4a68317
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 709fcbc
intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java PRE-CREATION
intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageService.java PRE-CREATION
repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 0325c80
repository/src/main/java/org/apache/atlas/discovery/InstanceLineageService.java PRE-CREATION
repository/src/main/scala/org/apache/atlas/query/ClosureQuery.scala 569d3f9
repository/src/test/java/org/apache/atlas/lineage/InstanceLineageServiceTest.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/rest/LineageREST.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/resources/InstanceLineageJerseyResourceIT.java PRE-CREATION
Diff: https://reviews.apache.org/r/53073/diff/
Testing
-------
Currently working on UT's
Thanks,
Sarath Subramanian
Re: Review Request 53073: Lineage REST API v2 implementation
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53073/
-----------------------------------------------------------
(Updated Nov. 3, 2016, 1:07 a.m.)
Review request for atlas, Apoorv Naik, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.
Changes
-------
unit tests for v2 lineage service
Bugs: ATLAS-1234
https://issues.apache.org/jira/browse/ATLAS-1234
Repository: atlas
Description
-------
Initial model for updated lineage rest apis for input, output and full lineage for dataset.
Diffs (updated)
-----
common/src/main/java/org/apache/atlas/repository/Constants.java 4a68317
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 709fcbc
intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java PRE-CREATION
intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageService.java PRE-CREATION
repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 0325c80
repository/src/main/java/org/apache/atlas/discovery/InstanceLineageService.java PRE-CREATION
repository/src/main/scala/org/apache/atlas/query/ClosureQuery.scala 569d3f9
repository/src/test/java/org/apache/atlas/lineage/InstanceLineageServiceTest.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/rest/LineageREST.java PRE-CREATION
Diff: https://reviews.apache.org/r/53073/diff/
Testing
-------
Currently working on UT's
Thanks,
Sarath Subramanian
Re: Review Request 53073: Lineage REST API v2 implementation
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53073/
-----------------------------------------------------------
(Updated Nov. 1, 2016, 11:28 a.m.)
Review request for atlas, Apoorv Naik, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.
Changes
-------
validating query params at api layer and passing to service layer.
Bugs: ATLAS-1234
https://issues.apache.org/jira/browse/ATLAS-1234
Repository: atlas
Description
-------
Initial model for updated lineage rest apis for input, output and full lineage for dataset.
Diffs (updated)
-----
common/src/main/java/org/apache/atlas/repository/Constants.java 4a68317
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 709fcbc
intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java PRE-CREATION
intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageService.java PRE-CREATION
repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 129591a
repository/src/main/java/org/apache/atlas/discovery/InstanceLineageService.java PRE-CREATION
repository/src/main/scala/org/apache/atlas/query/ClosureQuery.scala 569d3f9
webapp/src/main/java/org/apache/atlas/web/rest/LineageREST.java PRE-CREATION
Diff: https://reviews.apache.org/r/53073/diff/
Testing (updated)
-------
Currently working on UT's
Thanks,
Sarath Subramanian
Re: Review Request 53073: Lineage REST API v2 implementation
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53073/
-----------------------------------------------------------
(Updated Nov. 1, 2016, 12:09 a.m.)
Review request for atlas, Apoorv Naik, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.
Changes
-------
added atlas error codes to exceptions
Bugs: ATLAS-1234
https://issues.apache.org/jira/browse/ATLAS-1234
Repository: atlas
Description
-------
Initial model for updated lineage rest apis for input, output and full lineage for dataset.
Diffs (updated)
-----
common/src/main/java/org/apache/atlas/repository/Constants.java 4a68317
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 709fcbc
intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java PRE-CREATION
intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageService.java PRE-CREATION
repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 129591a
repository/src/main/java/org/apache/atlas/discovery/InstanceLineageService.java PRE-CREATION
repository/src/main/scala/org/apache/atlas/query/ClosureQuery.scala 569d3f9
webapp/src/main/java/org/apache/atlas/web/rest/LineageREST.java PRE-CREATION
Diff: https://reviews.apache.org/r/53073/diff/
Testing
-------
Currently working on UT's and to use Atlas error codes.
Thanks,
Sarath Subramanian