You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/10/26 00:07:20 UTC

[GitHub] [arrow-datafusion] xudong963 commented on a change in pull request #1167: DataFrame supports window function

xudong963 commented on a change in pull request #1167:
URL: https://github.com/apache/arrow-datafusion/pull/1167#discussion_r736049887



##########
File path: datafusion/src/sql/planner.rs
##########
@@ -840,24 +839,7 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
 
     /// Wrap a plan in a window
     fn window(&self, input: LogicalPlan, window_exprs: Vec<Expr>) -> Result<LogicalPlan> {

Review comment:
       nice caught!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org