You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by HyukjinKwon <gi...@git.apache.org> on 2018/02/10 08:34:51 UTC

[GitHub] spark pull request #20397: [SPARK-23219][SQL]Rename ReadTask to DataReaderFa...

Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20397#discussion_r167392663
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/RateSourceV2Suite.scala ---
    @@ -78,7 +78,7 @@ class RateSourceV2Suite extends StreamTest {
         val reader = new RateStreamMicroBatchReader(
           new DataSourceV2Options(Map("numPartitions" -> "11", "rowsPerSecond" -> "33").asJava))
         reader.setOffsetRange(Optional.empty(), Optional.empty())
    -    val tasks = reader.createReadTasks()
    +    val tasks = reader.createDataReaderFactories()
    --- End diff --
    
    nit: seems we should rename the variable too ..


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org