You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@apr.apache.org by bo...@apache.org on 2008/08/08 22:57:57 UTC
svn commit: r684091 - /apr/apr/branches/1.3.x/configure.in
Author: bojan
Date: Fri Aug 8 13:57:57 2008
New Revision: 684091
URL: http://svn.apache.org/viewvc?rev=684091&view=rev
Log:
Backport r683771 from the trunk.
Fix APR_PID_T_FMT detection on Solaris.
Patch by Rainer Jung <rainer.jung kippdata.de>.
Modified:
apr/apr/branches/1.3.x/configure.in
Modified: apr/apr/branches/1.3.x/configure.in
URL: http://svn.apache.org/viewvc/apr/apr/branches/1.3.x/configure.in?rev=684091&r1=684090&r2=684091&view=diff
==============================================================================
--- apr/apr/branches/1.3.x/configure.in (original)
+++ apr/apr/branches/1.3.x/configure.in Fri Aug 8 13:57:57 2008
@@ -1345,6 +1345,20 @@
socklen_t_value="int"
fi
+APR_CHECK_SIZEOF_EXTENDED([#include <sys/types.h>], pid_t, 8)
+
+if test "$ac_cv_sizeof_pid_t" = "$ac_cv_sizeof_short"; then
+ pid_t_fmt='#define APR_PID_T_FMT "hd"'
+elif test "$ac_cv_sizeof_pid_t" = "$ac_cv_sizeof_int"; then
+ pid_t_fmt='#define APR_PID_T_FMT "d"'
+elif test "$ac_cv_sizeof_pid_t" = "$ac_cv_sizeof_long"; then
+ pid_t_fmt='#define APR_PID_T_FMT "ld"'
+elif test "$ac_cv_sizeof_pid_t" = "$ac_cv_sizeof_long_long"; then
+ pid_t_fmt='#define APR_PID_T_FMT APR_INT64_T_FMT'
+else
+ pid_t_fmt='#error Can not determine the proper size for pid_t'
+fi
+
# Basically, we have tried to figure out the correct format strings
# for APR types which vary between platforms, but we don't always get
# it right.
@@ -1360,9 +1374,9 @@
;;
*-solaris*)
if test "$ac_cv_sizeof_long" = "8"; then
- pid_t_fmt="d"
+ pid_t_fmt='#define APR_PID_T_FMT "d"'
else
- pid_t_fmt="ld"
+ pid_t_fmt='#define APR_PID_T_FMT "ld"'
fi
;;
*aix4*|*aix5*)
@@ -1496,20 +1510,6 @@
fi
AC_MSG_NOTICE([using $ino_t_value for ino_t])
-APR_CHECK_SIZEOF_EXTENDED([#include <sys/types.h>], pid_t, 8)
-
-if test "$ac_cv_sizeof_pid_t" = "$ac_cv_sizeof_short"; then
- pid_t_fmt='#define APR_PID_T_FMT "hd"'
-elif test "$ac_cv_sizeof_pid_t" = "$ac_cv_sizeof_int"; then
- pid_t_fmt='#define APR_PID_T_FMT "d"'
-elif test "$ac_cv_sizeof_pid_t" = "$ac_cv_sizeof_long"; then
- pid_t_fmt='#define APR_PID_T_FMT "ld"'
-elif test "$ac_cv_sizeof_pid_t" = "$ac_cv_sizeof_long_long"; then
- pid_t_fmt='#define APR_PID_T_FMT APR_INT64_T_FMT'
-else
- pid_t_fmt='#error Can not determine the proper size for pid_t'
-fi
-
# Checks for endianness
AC_C_BIGENDIAN
if test $ac_cv_c_bigendian = yes; then
Re: svn commit: r684091 - /apr/apr/branches/1.3.x/configure.in
Posted by Bojan Smojver <bo...@rexursive.com>.
On Fri, 2008-08-08 at 16:35 -0500, William A. Rowe, Jr. wrote:
> Great, I presume both you and Rainer are now happy with this blended
> solution to Davi's initial report.
Rainer is the author of the patch, so he's obviously OK with it. Eric
also confirmed that it fixes the issue. I can't see any difference on
Linux, so nothing got upset (or so I hope :-).
--
Bojan
Re: svn commit: r684091 - /apr/apr/branches/1.3.x/configure.in
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Bojan Smojver wrote:
> On Fri, 2008-08-08 at 20:57 +0000, bojan@apache.org wrote:
>
>> Backport r683771 from the trunk.
>> Fix APR_PID_T_FMT detection on Solaris.
>> Patch by Rainer Jung <rainer.jung kippdata.de>.
>
> Nobody complained, so in it goes. Please pay attention to this when
> testing 1.3.3.
Great, I presume both you and Rainer are now happy with this blended
solution to Davi's initial report.
I'll tag in just a bit; guess you don't owe me that beverage (bout an
hour and a half later than I threatened)... then again a few of us owe
you a beverage if you make it to ApacheCon US, given all the elbow grease
you've put into backports. Thanks Bojan!
Bill
Re: svn commit: r684091 - /apr/apr/branches/1.3.x/configure.in
Posted by Bojan Smojver <bo...@rexursive.com>.
On Fri, 2008-08-08 at 20:57 +0000, bojan@apache.org wrote:
> Backport r683771 from the trunk.
> Fix APR_PID_T_FMT detection on Solaris.
> Patch by Rainer Jung <rainer.jung kippdata.de>.
Nobody complained, so in it goes. Please pay attention to this when
testing 1.3.3.
And yes, I did forget to put the PR number into the log again :-)
--
Bojan