You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/10/10 04:05:32 UTC

[GitHub] [kylin] hit-lacus commented on a change in pull request #1299: KYLIN-4613 add build cubev2 and JobRestClient

hit-lacus commented on a change in pull request #1299:
URL: https://github.com/apache/kylin/pull/1299#discussion_r502742763



##########
File path: core-common/src/main/java/org/apache/kylin/common/KylinConfig.java
##########
@@ -134,7 +134,7 @@ private static void buildDefaultOrderedProperties() {
         }
     }
 
-    public static KylinConfig getInstanceFromEnv() {
+    public static KylinConfig getInstanceFromEnv(boolean allowConfigFileNoExist) {

Review comment:
       Why we need `allowConfigFileNoExist` ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org