You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Henry Robinson (Code Review)" <ge...@cloudera.org> on 2017/06/19 19:04:17 UTC
[Impala-ASF-CR] IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7226
Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization
......................................................................
IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization
Change allocation pattern for Codec objects in RowBatch to be
stack-allocated. Make c'tors and Init() methods of codec implementations
publicly visible in order to do so.
Change-Id: Ia4b5a8d2cc315db50e5d70b1191702206de3450d
---
M be/src/runtime/row-batch.cc
M be/src/util/codec.h
M be/src/util/compress.h
M be/src/util/decompress.h
4 files changed, 57 insertions(+), 77 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/7226/1
--
To view, visit http://gerrit.cloudera.org:8080/7226
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia4b5a8d2cc315db50e5d70b1191702206de3450d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
[Impala-ASF-CR] IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization
......................................................................
Patch Set 4:
I fixed the placement of WARN_UNUSED_RESULT in the previous patchset, and also changed a method signature in the parquet writer so that the status of a compression operation could be checked. Please take another quick look at hdfs-parquet-table-writer.cc!
--
To view, visit http://gerrit.cloudera.org:8080/7226
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4b5a8d2cc315db50e5d70b1191702206de3450d
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization
......................................................................
Patch Set 3: Code-Review+2
Carry +2, rebase.
--
To view, visit http://gerrit.cloudera.org:8080/7226
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4b5a8d2cc315db50e5d70b1191702206de3450d
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, Michael Ho, Sailesh Mukil, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7226
to look at the new patch set (#5).
Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization
......................................................................
IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization
Change allocation pattern for Codec objects in RowBatch to be
stack-allocated. Make c'tors and Init() methods of codec implementations
publicly visible in order to do so.
Refactor HdfsParquetWriter etc. to deal properly with Status returned in
all cases.
Change-Id: Ia4b5a8d2cc315db50e5d70b1191702206de3450d
---
M be/src/exec/hdfs-avro-table-writer.cc
M be/src/exec/hdfs-parquet-table-writer.cc
M be/src/exec/hdfs-sequence-table-writer.cc
M be/src/exec/parquet-column-stats.cc
M be/src/exec/parquet-column-stats.h
M be/src/exec/parquet-column-stats.inline.h
M be/src/experiments/compression-test.cc
M be/src/runtime/row-batch.cc
M be/src/util/codec.h
M be/src/util/compress.h
M be/src/util/decompress-test.cc
M be/src/util/decompress.h
12 files changed, 160 insertions(+), 151 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/7226/5
--
To view, visit http://gerrit.cloudera.org:8080/7226
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia4b5a8d2cc315db50e5d70b1191702206de3450d
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change.
Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization
......................................................................
Patch Set 1:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/7226/1/be/src/runtime/row-batch.cc
File be/src/runtime/row-batch.cc:
PS1, Line 100: DCHECK(input_batch.compression_type == THdfsCompression::LZ4)
DCHECK_EQ();
Line 226: VLOG_ROW << "uncompressed size: " << size << ", compressed size: " << compressed_size;
> nit: Not your change.
Not your change either but it's unfortunate that we don't call Close() if ProcessBlock() fails above.
http://gerrit.cloudera.org:8080/#/c/7226/1/be/src/util/compress.h
File be/src/util/compress.h:
Line 47: virtual Status Init();
WARN_UNUSED_RESULT
http://gerrit.cloudera.org:8080/#/c/7226/1/be/src/util/decompress.h
File be/src/util/decompress.h:
PS1, Line 38: ;
WARN_UNUSED_RESULT. Same below.
Line 41: const uint8_t* input, int64_t* output_length, uint8_t** output);
WARN_UNUSED_RESULT. Same below.
Line 44: bool* stream_end);
WARN_UNUSED_RESULT. Same below.
--
To view, visit http://gerrit.cloudera.org:8080/7226
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4b5a8d2cc315db50e5d70b1191702206de3450d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization
......................................................................
Patch Set 3:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/761/
--
To view, visit http://gerrit.cloudera.org:8080/7226
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4b5a8d2cc315db50e5d70b1191702206de3450d
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization
......................................................................
Patch Set 4:
Sorry that was a link to the wrong commit, this is the branch with the correct one https://github.com/timarmstrong/incubator-impala/commits/fix-table-writers
--
To view, visit http://gerrit.cloudera.org:8080/7226
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4b5a8d2cc315db50e5d70b1191702206de3450d
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization
......................................................................
Patch Set 3: Verified-1
Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/761/
--
To view, visit http://gerrit.cloudera.org:8080/7226
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4b5a8d2cc315db50e5d70b1191702206de3450d
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7226/1/be/src/runtime/row-batch.cc
File be/src/runtime/row-batch.cc:
Line 226: VLOG_ROW << "uncompressed size: " << size << ", compressed size: " << compressed_size;
nit: Not your change.
It's a no-op, but I think we should call compressor.Close() to be consistent.
--
To view, visit http://gerrit.cloudera.org:8080/7226
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4b5a8d2cc315db50e5d70b1191702206de3450d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has abandoned this change.
Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization
......................................................................
Abandoned
Bad merge - will restore when I fix it.
--
To view, visit http://gerrit.cloudera.org:8080/7226
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ia4b5a8d2cc315db50e5d70b1191702206de3450d
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, Michael Ho, Sailesh Mukil, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7226
to look at the new patch set (#4).
Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization
......................................................................
IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization
Change allocation pattern for Codec objects in RowBatch to be
stack-allocated. Make c'tors and Init() methods of codec implementations
publicly visible in order to do so.
Change signature of BaseColumnWriter::FinalizeCurrentPage() so that
result of ProcessBlock32() can be properly checked.
Change-Id: Ia4b5a8d2cc315db50e5d70b1191702206de3450d
---
M be/src/exec/hdfs-parquet-table-writer.cc
M be/src/experiments/compression-test.cc
M be/src/runtime/row-batch.cc
M be/src/util/codec.h
M be/src/util/compress.h
M be/src/util/decompress-test.cc
M be/src/util/decompress.h
7 files changed, 119 insertions(+), 122 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/7226/4
--
To view, visit http://gerrit.cloudera.org:8080/7226
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia4b5a8d2cc315db50e5d70b1191702206de3450d
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7226
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4b5a8d2cc315db50e5d70b1191702206de3450d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change.
Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7226
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4b5a8d2cc315db50e5d70b1191702206de3450d
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization
......................................................................
Patch Set 1:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/7226/1/be/src/runtime/row-batch.cc
File be/src/runtime/row-batch.cc:
PS1, Line 100: DCHECK(input_batch.compression_type == THdfsCompression::LZ4)
> DCHECK_EQ();
Done
Line 226: VLOG_ROW << "uncompressed size: " << size << ", compressed size: " << compressed_size;
> Not your change either but it's unfortunate that we don't call Close() if P
Done - used a ScopedExitTrigger to make Close() is always called.
http://gerrit.cloudera.org:8080/#/c/7226/1/be/src/util/compress.h
File be/src/util/compress.h:
Line 47: virtual Status Init();
> WARN_UNUSED_RESULT
Done
http://gerrit.cloudera.org:8080/#/c/7226/1/be/src/util/decompress.h
File be/src/util/decompress.h:
PS1, Line 38: ;
> WARN_UNUSED_RESULT. Same below.
Done
Line 41: const uint8_t* input, int64_t* output_length, uint8_t** output);
> WARN_UNUSED_RESULT. Same below.
Done
Line 44: bool* stream_end);
> WARN_UNUSED_RESULT. Same below.
Done
--
To view, visit http://gerrit.cloudera.org:8080/7226
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4b5a8d2cc315db50e5d70b1191702206de3450d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Hello Sailesh Mukil, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7226
to look at the new patch set (#2).
Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization
......................................................................
IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization
Change allocation pattern for Codec objects in RowBatch to be
stack-allocated. Make c'tors and Init() methods of codec implementations
publicly visible in order to do so.
Change-Id: Ia4b5a8d2cc315db50e5d70b1191702206de3450d
---
M be/src/runtime/row-batch.cc
M be/src/util/codec.h
M be/src/util/compress.h
M be/src/util/decompress.h
4 files changed, 93 insertions(+), 104 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/7226/2
--
To view, visit http://gerrit.cloudera.org:8080/7226
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia4b5a8d2cc315db50e5d70b1191702206de3450d
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7226/4/be/src/exec/hdfs-parquet-table-writer.cc
File be/src/exec/hdfs-parquet-table-writer.cc:
Line 327: Status status = FinalizeCurrentPage();
This doesn't seem right - why return a Status if we're going to assume that it's always ok.
I actually had a branch where I was going through and fixing all the dropped statuses found by GCC7's [[nodiscard]]. My fixes for propagating the table writer status are here:
https://github.com/timarmstrong/incubator-impala/commit/6a9cb5a1d79c52001597b58eb073ff5b70a239f4
I already ran a build with these fixes. Maybe we can just fold that into here.
--
To view, visit http://gerrit.cloudera.org:8080/7226
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4b5a8d2cc315db50e5d70b1191702206de3450d
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes