You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/19 08:34:33 UTC
[GitHub] [flink] JingsongLi opened a new pull request #12241: [FLINK-17474][parquet][hive] Parquet reader should be case insensitive for hive
JingsongLi opened a new pull request #12241:
URL: https://github.com/apache/flink/pull/12241
## What is the purpose of the change
Parquet reader should be case insensitive field names for hive
## Brief change log
- Introduce case sensitive flag to parquet reader
- For hive, the case sensitive flag is false
## Verifying this change
`HiveTableSourceTest.testParquetCaseInsensitive`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12241: [FLINK-17474][parquet][hive] Parquet reader should be case insensitive for hive
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12241:
URL: https://github.com/apache/flink/pull/12241#issuecomment-630692649
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "784c1dc168979a6165e22ea31cd1d152dbb818e2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1825",
"triggerID" : "784c1dc168979a6165e22ea31cd1d152dbb818e2",
"triggerType" : "PUSH"
}, {
"hash" : "a16df2eb5401a92070e634c13fbc27d445069671",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1836",
"triggerID" : "a16df2eb5401a92070e634c13fbc27d445069671",
"triggerType" : "PUSH"
}, {
"hash" : "5a0b352ffaee344516f62759f838a355d21eac09",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5a0b352ffaee344516f62759f838a355d21eac09",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a16df2eb5401a92070e634c13fbc27d445069671 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1836)
* 5a0b352ffaee344516f62759f838a355d21eac09 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi merged pull request #12241: [FLINK-17474][parquet][hive] Parquet reader should be case insensitive for hive
Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #12241:
URL: https://github.com/apache/flink/pull/12241
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12241: [FLINK-17474][parquet][hive] Parquet reader should be case insensitive for hive
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12241:
URL: https://github.com/apache/flink/pull/12241#issuecomment-630692649
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "784c1dc168979a6165e22ea31cd1d152dbb818e2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1825",
"triggerID" : "784c1dc168979a6165e22ea31cd1d152dbb818e2",
"triggerType" : "PUSH"
}, {
"hash" : "a16df2eb5401a92070e634c13fbc27d445069671",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1836",
"triggerID" : "a16df2eb5401a92070e634c13fbc27d445069671",
"triggerType" : "PUSH"
}, {
"hash" : "5a0b352ffaee344516f62759f838a355d21eac09",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1981",
"triggerID" : "5a0b352ffaee344516f62759f838a355d21eac09",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a16df2eb5401a92070e634c13fbc27d445069671 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1836)
* 5a0b352ffaee344516f62759f838a355d21eac09 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1981)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12241: [FLINK-17474][parquet][hive] Parquet reader should be case insensitive for hive
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12241:
URL: https://github.com/apache/flink/pull/12241#issuecomment-630673426
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 784c1dc168979a6165e22ea31cd1d152dbb818e2 (Tue May 19 08:36:17 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12241: [FLINK-17474][parquet][hive] Parquet reader should be case insensitive for hive
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12241:
URL: https://github.com/apache/flink/pull/12241#issuecomment-630692649
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "784c1dc168979a6165e22ea31cd1d152dbb818e2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1825",
"triggerID" : "784c1dc168979a6165e22ea31cd1d152dbb818e2",
"triggerType" : "PUSH"
}, {
"hash" : "a16df2eb5401a92070e634c13fbc27d445069671",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1836",
"triggerID" : "a16df2eb5401a92070e634c13fbc27d445069671",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 784c1dc168979a6165e22ea31cd1d152dbb818e2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1825)
* a16df2eb5401a92070e634c13fbc27d445069671 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1836)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12241: [FLINK-17474][parquet][hive] Parquet reader should be case insensitive for hive
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12241:
URL: https://github.com/apache/flink/pull/12241#issuecomment-630673426
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 5a0b352ffaee344516f62759f838a355d21eac09 (Fri Oct 16 10:52:48 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12241: [FLINK-17474][parquet][hive] Parquet reader should be case insensitive for hive
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12241:
URL: https://github.com/apache/flink/pull/12241#issuecomment-630692649
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "784c1dc168979a6165e22ea31cd1d152dbb818e2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1825",
"triggerID" : "784c1dc168979a6165e22ea31cd1d152dbb818e2",
"triggerType" : "PUSH"
}, {
"hash" : "a16df2eb5401a92070e634c13fbc27d445069671",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1836",
"triggerID" : "a16df2eb5401a92070e634c13fbc27d445069671",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a16df2eb5401a92070e634c13fbc27d445069671 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1836)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12241: [FLINK-17474][parquet][hive] Parquet reader should be case insensitive for hive
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12241:
URL: https://github.com/apache/flink/pull/12241#issuecomment-630692649
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "784c1dc168979a6165e22ea31cd1d152dbb818e2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1825",
"triggerID" : "784c1dc168979a6165e22ea31cd1d152dbb818e2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 784c1dc168979a6165e22ea31cd1d152dbb818e2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1825)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12241: [FLINK-17474][parquet][hive] Parquet reader should be case insensitive for hive
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12241:
URL: https://github.com/apache/flink/pull/12241#issuecomment-630692649
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "784c1dc168979a6165e22ea31cd1d152dbb818e2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "784c1dc168979a6165e22ea31cd1d152dbb818e2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 784c1dc168979a6165e22ea31cd1d152dbb818e2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12241: [FLINK-17474][parquet][hive] Parquet reader should be case insensitive for hive
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12241:
URL: https://github.com/apache/flink/pull/12241#issuecomment-630692649
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "784c1dc168979a6165e22ea31cd1d152dbb818e2",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1825",
"triggerID" : "784c1dc168979a6165e22ea31cd1d152dbb818e2",
"triggerType" : "PUSH"
}, {
"hash" : "a16df2eb5401a92070e634c13fbc27d445069671",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1836",
"triggerID" : "a16df2eb5401a92070e634c13fbc27d445069671",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 784c1dc168979a6165e22ea31cd1d152dbb818e2 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1825)
* a16df2eb5401a92070e634c13fbc27d445069671 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1836)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12241: [FLINK-17474][parquet][hive] Parquet reader should be case insensitive for hive
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12241:
URL: https://github.com/apache/flink/pull/12241#issuecomment-630692649
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "784c1dc168979a6165e22ea31cd1d152dbb818e2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1825",
"triggerID" : "784c1dc168979a6165e22ea31cd1d152dbb818e2",
"triggerType" : "PUSH"
}, {
"hash" : "a16df2eb5401a92070e634c13fbc27d445069671",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a16df2eb5401a92070e634c13fbc27d445069671",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 784c1dc168979a6165e22ea31cd1d152dbb818e2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1825)
* a16df2eb5401a92070e634c13fbc27d445069671 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org