You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/05/12 08:14:24 UTC
[GitHub] [mynewt-nimble] KKopyscinski opened a new pull request #977: ble_att_svr: fix keysize check for SC Only mode
KKopyscinski opened a new pull request #977:
URL: https://github.com/apache/mynewt-nimble/pull/977
Keysize for level 4 security is 16 Bytes not 128 bits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] KKopyscinski commented on pull request #977: ble_att_svr: fix keysize check for SC Only mode
Posted by GitBox <gi...@apache.org>.
KKopyscinski commented on pull request #977:
URL: https://github.com/apache/mynewt-nimble/pull/977#issuecomment-839715582
Indeed, 16 bytes are 128 bits. Edited commit message :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] KKopyscinski merged pull request #977: ble_att_svr: fix keysize check for SC Only mode
Posted by GitBox <gi...@apache.org>.
KKopyscinski merged pull request #977:
URL: https://github.com/apache/mynewt-nimble/pull/977
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #977: ble_att_svr: fix keysize check for SC Only mode
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #977:
URL: https://github.com/apache/mynewt-nimble/pull/977#issuecomment-839572645
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc commented on pull request #977: ble_att_svr: fix keysize check for SC Only mode
Posted by GitBox <gi...@apache.org>.
sjanc commented on pull request #977:
URL: https://github.com/apache/mynewt-nimble/pull/977#issuecomment-839713015
16 bytes are 128bits :-) I'd adjust commit message to something like "keysize is kept in bytes and not bits" or similar :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org