You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by mi...@apache.org on 2011/11/12 00:29:14 UTC
svn commit: r1201099 - /lucene/dev/trunk/lucene/src/java/org/apache/lucene/search/FieldComparator.java

Author: mikemccand
Date: Fri Nov 11 23:29:13 2011
New Revision: 1201099

URL: http://svn.apache.org/viewvc?rev=1201099&view=rev
Log:
add comments

Modified:
    lucene/dev/trunk/lucene/src/java/org/apache/lucene/search/FieldComparator.java

Modified: lucene/dev/trunk/lucene/src/java/org/apache/lucene/search/FieldComparator.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/src/java/org/apache/lucene/search/FieldComparator.java?rev=1201099&r1=1201098&r2=1201099&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/src/java/org/apache/lucene/search/FieldComparator.java (original)
+++ lucene/dev/trunk/lucene/src/java/org/apache/lucene/search/FieldComparator.java Fri Nov 11 23:29:13 2011
@@ -258,6 +258,8 @@ public abstract class FieldComparator<T>
 
     @Override
     public FieldComparator setNextReader(AtomicReaderContext context) throws IOException {
+      // NOTE: must do this before calling super otherwise
+      // we compute the docsWithField Bits twice!
       currentReaderValues = FieldCache.DEFAULT.getBytes(context.reader, field, parser, missingValue != null);
       return super.setNextReader(context);
     }
@@ -333,6 +335,8 @@ public abstract class FieldComparator<T>
 
     @Override
     public FieldComparator setNextReader(AtomicReaderContext context) throws IOException {
+      // NOTE: must do this before calling super otherwise
+      // we compute the docsWithField Bits twice!
       currentReaderValues = FieldCache.DEFAULT.getDoubles(context.reader, field, parser, missingValue != null);
       return super.setNextReader(context);
     }
@@ -472,6 +476,8 @@ public abstract class FieldComparator<T>
 
     @Override
     public FieldComparator setNextReader(AtomicReaderContext context) throws IOException {
+      // NOTE: must do this before calling super otherwise
+      // we compute the docsWithField Bits twice!
       currentReaderValues = FieldCache.DEFAULT.getFloats(context.reader, field, parser, missingValue != null);
       return super.setNextReader(context);
     }
@@ -532,6 +538,8 @@ public abstract class FieldComparator<T>
 
     @Override
     public FieldComparator setNextReader(AtomicReaderContext context) throws IOException {
+      // NOTE: must do this before calling super otherwise
+      // we compute the docsWithField Bits twice!
       currentReaderValues = FieldCache.DEFAULT.getShorts(context.reader, field, parser, missingValue != null);
       return super.setNextReader(context);
     }
@@ -614,6 +622,8 @@ public abstract class FieldComparator<T>
 
     @Override
     public FieldComparator setNextReader(AtomicReaderContext context) throws IOException {
+      // NOTE: must do this before calling super otherwise
+      // we compute the docsWithField Bits twice!
       currentReaderValues = FieldCache.DEFAULT.getInts(context.reader, field, parser, missingValue != null);
       return super.setNextReader(context);
     }
@@ -758,6 +768,8 @@ public abstract class FieldComparator<T>
 
     @Override
     public FieldComparator setNextReader(AtomicReaderContext context) throws IOException {
+      // NOTE: must do this before calling super otherwise
+      // we compute the docsWithField Bits twice!
       currentReaderValues = FieldCache.DEFAULT.getLongs(context.reader, field, parser, missingValue != null);
       return super.setNextReader(context);
     }