[GitHub] [hbase] Apache9 commented on a change in pull request #1223: HBASE-23739 BoundedRecoveredHFilesOutputSink should read the table de…

[GitBox <gi...@apache.org>]

Apache9 commented on a change in pull request #1223: HBASE-23739 BoundedRecoveredHFilesOutputSink should read the table de…
URL: https://github.com/apache/hbase/pull/1223#discussion_r385983902
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
 ##########
 @@ -721,20 +720,20 @@ private void initializeFileSystem() throws IOException {
   }
 
   private TableDescriptors getFsTableDescriptors() throws IOException {
-    return new FSTableDescriptors(this.conf,
-      this.dataFs, this.dataRootDir, !canUpdateTableDescriptor(), false, getMetaTableObserver());
-  }
-
-  protected Function<TableDescriptorBuilder, TableDescriptorBuilder> getMetaTableObserver() {
-    return null;
+    if (canUpdateTableDescriptor()) {
+      return new FSTableDescriptors(this.conf, this.dataFs, this.dataRootDir, false,
+        builder -> builder.setRegionReplication(
 
 Review comment:
   This changes the semantic? Not sure why but before this patch we only set this for HMaster?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services