You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/09/20 16:24:54 UTC
[GitHub] [dolphinscheduler] github-code-scanning[bot] commented on a diff in pull request #12073: [Improvement][Dependent] The project list in dependent node's permissions should not be restricted
github-code-scanning[bot] commented on code in PR #12073:
URL: https://github.com/apache/dolphinscheduler/pull/12073#discussion_r975580876
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProjectV2Controller.java:
##########
@@ -288,4 +288,20 @@
Result result = projectService.queryAllProjectList(loginUser);
return new ProjectListResponse(result);
}
+
+ /**
+ * query all project list for dependent
+ *
+ * @param loginUser login user
+ * @return all project list
+ */
+ @ApiOperation(value = "queryAllProjectListForDependent", notes = "QUERY_ALL_PROJECT_LIST_FOR_DEPENDENT_NOTES")
+ @GetMapping(value = "/list-dependent")
+ @ResponseStatus(HttpStatus.OK)
+ @ApiException(LOGIN_USER_QUERY_PROJECT_LIST_PAGING_ERROR)
+ @AccessLogAnnotation(ignoreRequestArgs = "loginUser")
+ public ProjectListResponse queryAllProjectListForDependent(@ApiIgnore @RequestAttribute(value = Constants.SESSION_USER) User loginUser) {
Review Comment:
## Useless parameter
The parameter loginUser is unused.
[Show more details](https://github.com/apache/dolphinscheduler/security/code-scanning/1494)
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProjectController.java:
##########
@@ -284,4 +284,19 @@
public Result queryAllProjectList(@ApiIgnore @RequestAttribute(value = Constants.SESSION_USER) User loginUser) {
return projectService.queryAllProjectList(loginUser);
}
+
+ /**
+ * query all project list for dependent
+ *
+ * @param loginUser login user
+ * @return all project list
+ */
+ @ApiOperation(value = "queryAllProjectListForDependent", notes = "QUERY_ALL_PROJECT_LIST_FOR_DEPENDENT_NOTES")
+ @GetMapping(value = "/list-dependent")
+ @ResponseStatus(HttpStatus.OK)
+ @ApiException(LOGIN_USER_QUERY_PROJECT_LIST_PAGING_ERROR)
+ @AccessLogAnnotation(ignoreRequestArgs = "loginUser")
+ public Result queryAllProjectListForDependent(@ApiIgnore @RequestAttribute(value = Constants.SESSION_USER) User loginUser) {
Review Comment:
## Useless parameter
The parameter loginUser is unused.
[Show more details](https://github.com/apache/dolphinscheduler/security/code-scanning/1493)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org