You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Arkoniak <gi...@git.apache.org> on 2016/06/02 07:42:01 UTC
[GitHub] incubator-zeppelin pull request #949: [ZEPPELIN-941] jsoup NoSuchMethodError...
GitHub user Arkoniak opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/949
[ZEPPELIN-941] jsoup NoSuchMethodError in ZeppelinRDisplay.scala
### What is this PR for?
Since version 1.8.2 of jsoup, org.jsoup.select.Elements class no longer has "get(int index)" method. It contradicts to <jsoup.version>1.8.2</jsoup.version> written in scala/pom.xml. Currently %r scripts fail with "java.lang.NoSuchMethodError: org.jsoup.select.Elements.get(I)Lorg/jsoup/nodes/Element;"
This PR changes obsolete get(0) method to more universal and logically equivalent first() method, removing error message and removing 1.8.1 restriction to jsoup library (at least in ZeppelinRDisplay part of zeppelin).
### What type of PR is it?
Bug Fix
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-941
### How should this be tested?
Execute R-Tutorial Notebook in default installation of zeppelin and confirm that you can see output.
### Questions:
It shouldn't break older versions.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Arkoniak/incubator-zeppelin rdisplay_jsoup_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/949.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #949
----
commit 8597610642d0941158d87e56e3ef95af245351fd
Author: Andrey Oskin <a....@corp.mail.ru>
Date: 2016-06-02T07:12:38Z
jsoup get(0) to first()
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #949: [ZEPPELIN-941] jsoup NoSuchMethodError in Zep...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/949
CI failure is un-related
```
08:00:02,254 ERROR org.apache.zeppelin.AbstractZeppelinIT:153 - Exception in ZeppelinIT while testSparkInterpreterDependencyLoading
org.openqa.selenium.TimeoutException: Timed out after 30 seconds waiting for visibility of element located by By.id: noteNameModal
...
at org.apache.zeppelin.AbstractZeppelinIT.createNewNote(AbstractZeppelinIT.java:133)
```
@Arkoniak can you please close and re-open the issue to trigger the CI?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request #949: [ZEPPELIN-941] jsoup NoSuchMethodError...
Posted by Arkoniak <gi...@git.apache.org>.
GitHub user Arkoniak reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/949
[ZEPPELIN-941] jsoup NoSuchMethodError in ZeppelinRDisplay.scala
### What is this PR for?
Since version 1.8.2 of jsoup, org.jsoup.select.Elements class no longer has "get(int index)" method. It contradicts to <jsoup.version>1.8.2</jsoup.version> written in scala/pom.xml. Currently %r scripts fail with "java.lang.NoSuchMethodError: org.jsoup.select.Elements.get(I)Lorg/jsoup/nodes/Element;"
This PR changes obsolete get(0) method to more universal and logically equivalent first() method, removing error message and removing 1.8.1 restriction to jsoup library (at least in ZeppelinRDisplay part of zeppelin).
### What type of PR is it?
Bug Fix
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-941
### How should this be tested?
Execute R-Tutorial Notebook in default installation of zeppelin and confirm that you can see output.
### Questions:
It shouldn't break older versions.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Arkoniak/incubator-zeppelin rdisplay_jsoup_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/949.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #949
----
commit 8597610642d0941158d87e56e3ef95af245351fd
Author: Andrey Oskin <a....@corp.mail.ru>
Date: 2016-06-02T07:12:38Z
jsoup get(0) to first()
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #949: [ZEPPELIN-941] jsoup NoSuchMethodError in Zep...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/949
Thanks! Lets wait for results, in effort to stabilize the CI.
Otherwise looks great to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #949: [ZEPPELIN-941] jsoup NoSuchMethodError in Zep...
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/949
All Green now. LGTM confirmed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request #949: [ZEPPELIN-941] jsoup NoSuchMethodError...
Posted by Arkoniak <gi...@git.apache.org>.
GitHub user Arkoniak reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/949
[ZEPPELIN-941] jsoup NoSuchMethodError in ZeppelinRDisplay.scala
### What is this PR for?
Since version 1.8.2 of jsoup, org.jsoup.select.Elements class no longer has "get(int index)" method. It contradicts to <jsoup.version>1.8.2</jsoup.version> written in scala/pom.xml. Currently %r scripts fail with "java.lang.NoSuchMethodError: org.jsoup.select.Elements.get(I)Lorg/jsoup/nodes/Element;"
This PR changes obsolete get(0) method to more universal and logically equivalent first() method, removing error message and removing 1.8.1 restriction to jsoup library (at least in ZeppelinRDisplay part of zeppelin).
### What type of PR is it?
Bug Fix
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-941
### How should this be tested?
Execute R-Tutorial Notebook in default installation of zeppelin and confirm that you can see output.
### Questions:
It shouldn't break older versions.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Arkoniak/incubator-zeppelin rdisplay_jsoup_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/949.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #949
----
commit 3d054006bfc3ad63fbf988778098b2a27443a190
Author: Andrey Oskin <a....@corp.mail.ru>
Date: 2016-06-02T07:12:38Z
jsoup get(0) to first()
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #949: [ZEPPELIN-941] jsoup NoSuchMethodError in Zep...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/949
\U0001f44d Merging if there is no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #949: [ZEPPELIN-941] jsoup NoSuchMethodError in Zep...
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/949
Thx for jumping on this. It was mentioned on the mailing list, but seems like not everyone encounters this (maybe different maven options, profiles...)
Going to first will solve issue for everyone.
I checked Travis: all green execept TEST_SELENIUM=true which returns : `Tests in error: ZeppelinIT.testSparkInterpreterDependencyLoading:214->AbstractZeppelinIT.createNewNote:133 ยป Timeout` - Not related to this PR.
So LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request #949: [ZEPPELIN-941] jsoup NoSuchMethodError...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/949
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request #949: [ZEPPELIN-941] jsoup NoSuchMethodError...
Posted by Arkoniak <gi...@git.apache.org>.
Github user Arkoniak closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/949
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request #949: [ZEPPELIN-941] jsoup NoSuchMethodError...
Posted by Arkoniak <gi...@git.apache.org>.
Github user Arkoniak closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/949
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---