Re: [PR] feat(services/oss): Implement `Write Returns Metadata` for oss [opendal]

["meteorgan (via GitHub)" <gi...@apache.org>]

meteorgan commented on code in PR #5688:
URL: https://github.com/apache/opendal/pull/5688#discussion_r1977714903


##########
core/src/services/oss/writer.rs:
##########
@@ -41,6 +41,21 @@ impl OssWriter {
             op,
         }
     }
+
+    fn parse_metadata(headers: &HeaderMap<HeaderValue>) -> Result<Metadata> {
+        let mut meta = Metadata::default();
+        if let Some(etag) = parse_etag(headers)? {
+            meta.set_etag(etag);
+        }
+        if let Some(md5) = parse_content_md5(headers)? {

Review Comment:
   Only `PutObject` responds with `content_md5`, so I didn't enable `write_has_content_md5`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org