[GitHub] eric-haibin-lin commented on a change in pull request #12477: Added build with nccl

[GitBox <gi...@apache.org>]

eric-haibin-lin commented on a change in pull request #12477: Added build with nccl
URL: https://github.com/apache/incubator-mxnet/pull/12477#discussion_r232499024
 
 

 ##########
 File path: src/operator/tensor/elemwise_unary_op_basic.cc
 ##########
 @@ -30,11 +30,11 @@ namespace mxnet {
 namespace op {
 
 // infer storage function for _identity_with_attr_like_rhs op
-static bool IdentityAttrLikeRhsStorageType(const nnvm::NodeAttrs& attrs,
-                                           const int dev_mask,
-                                           DispatchMode* dispatch_mode,
-                                           std::vector<int> *in_attrs,
-                                           std::vector<int> *out_attrs) {
+static bool InferStorage(const nnvm::NodeAttrs &attrs,
 
 Review comment:
   I'm afraid mxnet::op::InferStorage is too generic while its implementation is only for `_identity_with_attr_like_rhs` op. This will cause confusion

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services