You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@predictionio.apache.org by do...@apache.org on 2016/07/18 20:18:03 UTC
[32/34] incubator-predictionio git commit: fix more private scopes
fix more private scopes
Project: http://git-wip-us.apache.org/repos/asf/incubator-predictionio/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-predictionio/commit/64280b19
Tree: http://git-wip-us.apache.org/repos/asf/incubator-predictionio/tree/64280b19
Diff: http://git-wip-us.apache.org/repos/asf/incubator-predictionio/diff/64280b19
Branch: refs/heads/develop
Commit: 64280b195e23a910371c88105ad6b9414a404c44
Parents: d7c1417
Author: Xusen Yin <yi...@gmail.com>
Authored: Thu Jul 7 17:16:29 2016 -0700
Committer: Xusen Yin <yi...@gmail.com>
Committed: Thu Jul 7 17:16:29 2016 -0700
----------------------------------------------------------------------
.../scala/org/apache/predictionio/controller/Deployment.scala | 2 +-
.../scala/org/apache/predictionio/controller/Evaluation.scala | 4 ++--
.../main/scala/org/apache/predictionio/controller/Metric.scala | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-predictionio/blob/64280b19/core/src/main/scala/org/apache/predictionio/controller/Deployment.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/org/apache/predictionio/controller/Deployment.scala b/core/src/main/scala/org/apache/predictionio/controller/Deployment.scala
index 76fe0b3..fa7f3f1 100644
--- a/core/src/main/scala/org/apache/predictionio/controller/Deployment.scala
+++ b/core/src/main/scala/org/apache/predictionio/controller/Deployment.scala
@@ -34,7 +34,7 @@ trait Deployment extends EngineFactory {
}
/** Returns the [[Engine]] contained in this [[Deployment]]. */
- private [prediction]
+ private[predictionio]
def engine: BaseEngine[_, _, _, _] = {
assert(engineSet, "Engine not set")
_engine
http://git-wip-us.apache.org/repos/asf/incubator-predictionio/blob/64280b19/core/src/main/scala/org/apache/predictionio/controller/Evaluation.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/org/apache/predictionio/controller/Evaluation.scala b/core/src/main/scala/org/apache/predictionio/controller/Evaluation.scala
index c720c4f..79fa3a2 100644
--- a/core/src/main/scala/org/apache/predictionio/controller/Evaluation.scala
+++ b/core/src/main/scala/org/apache/predictionio/controller/Evaluation.scala
@@ -32,7 +32,7 @@ trait Evaluation extends Deployment {
protected [this] var _evaluatorSet: Boolean = false
protected [this] var _evaluator: BaseEvaluator[_, _, _, _, _ <: BaseEvaluatorResult] = _
- private [prediction]
+ private[predictionio]
def evaluator: BaseEvaluator[_, _, _, _, _ <: BaseEvaluatorResult] = {
assert(_evaluatorSet, "Evaluator not set")
_evaluator
@@ -95,7 +95,7 @@ trait Evaluation extends Deployment {
outputPath = "best.json"))
}
- private [prediction]
+ private[predictionio]
def engineMetrics: (BaseEngine[_, _, _, _], Metric[_, _, _, _, _]) = {
throw new NotImplementedError("This method is to keep the compiler happy")
}
http://git-wip-us.apache.org/repos/asf/incubator-predictionio/blob/64280b19/core/src/main/scala/org/apache/predictionio/controller/Metric.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/org/apache/predictionio/controller/Metric.scala b/core/src/main/scala/org/apache/predictionio/controller/Metric.scala
index cc27984..712d537 100644
--- a/core/src/main/scala/org/apache/predictionio/controller/Metric.scala
+++ b/core/src/main/scala/org/apache/predictionio/controller/Metric.scala
@@ -54,7 +54,7 @@ extends Serializable {
def compare(r0: R, r1: R): Int = rOrder.compare(r0, r1)
}
-private [prediction] trait StatsMetricHelper[EI, Q, P, A] {
+private[predictionio] trait StatsMetricHelper[EI, Q, P, A] {
def calculate(q: Q, p: P, a: A): Double
def calculateStats(sc: SparkContext, evalDataSet: Seq[(EI, RDD[(Q, P, A)])])
@@ -69,7 +69,7 @@ private [prediction] trait StatsMetricHelper[EI, Q, P, A] {
}
}
-private [prediction] trait StatsOptionMetricHelper[EI, Q, P, A] {
+private[predictionio] trait StatsOptionMetricHelper[EI, Q, P, A] {
def calculate(q: Q, p: P, a: A): Option[Double]
def calculateStats(sc: SparkContext, evalDataSet: Seq[(EI, RDD[(Q, P, A)])])