[GitHub] [skywalking-banyandb] lujiajing1126 commented on a diff in pull request #164: Add streaming API and topN aggregator

[GitBox <gi...@apache.org>]

lujiajing1126 commented on code in PR #164:
URL: https://github.com/apache/skywalking-banyandb/pull/164#discussion_r992298785


##########
banyand/measure/measure_write.go:
##########
@@ -55,6 +56,15 @@ func (s *measure) Write(value *measurev1.DataPointValue) error {
 		close(waitCh)
 		return err
 	}
+	// send to stream processor

Review Comment:
   We have a `topNProcessCallback` to listen from the pipeline.
   
   The `Write` method here should both,
   1) write measure to the storage and,
   2) send it for streaming processing.
   
   THIS IS ONLY FOR TESTING.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org