You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/26 19:17:56 UTC

[GitHub] [airflow] potiuk commented on issue #26644: Shedule details in default_args does not get passed to DAG model

potiuk commented on issue #26644:
URL: https://github.com/apache/airflow/issues/26644#issuecomment-1258503175

   > My point is that labeling the argument as default_args is potentially confusing because it is passed as an argument to the Dag and therefore could be understood as something that will be applied to the Dag.
   > It should be named something like default_task_args or default_operator_args to make it apparent that it is applied to tasks within the dag rather than the dag itself.
   
   My opinion It's definitely not a bug. It's how it is defined. There is no ultimate best approach how it **should** be named. You can have an opinion on that but unless you are ready to pay the cost of changing it, this is an opinion, and it's not a bug, and while it **could** be named differently, it is not. But defintely **should** and **bug** are not appropriate for that.
   
   Just to set expectations here you are free to open a discussion in the devlist. This is that caliber of a change that will impact literally milions of dags "in the wild" and changing mindset of tens of thousands of yousers who used 'default_args" for about 8-9 years, I hope you are prepared to defend that all the cost involved in changing it for all the users. And you are well prepared to lead the change? 
   
   This is how open source works - if you do not like something, you not only propose it, but you usually have to defend it, justify cost of change, leading it to completion and then answering questions of users when the change is implemented. Airlfow is created by ~ 2200 users like you and this is usually what happens when you want to improve something that you are responsible for convincing others that this is worth it and then implementing it. You would have to discuss it, get others to agree and change your opinion into a decision by the community.
   
   I am quite sure that there are many more improvements that have far less cost and more impact, but if you would like to start discussion on it (and then providing it will succed) lead the implementation of it, feel free - devlist is where such proposal should happen. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org