Re: [PR] Core: v4 table metadata location should be optional [iceberg]

["danielcweeks (via GitHub)" <gi...@apache.org>]

danielcweeks commented on code in PR #16572:
URL: https://github.com/apache/iceberg/pull/16572#discussion_r3336576855


##########
api/src/main/java/org/apache/iceberg/Files.java:
##########
@@ -40,6 +40,9 @@ public static OutputFile localOutput(File file) {
   }
 
   public static OutputFile localOutput(String file) {
+    if (file.startsWith("file:")) {

Review Comment:
   We should probably pull this up to a constant rather than inlining the scheme.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org